Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: IPRPC pool rewards distribution #1678

Merged
merged 11 commits into from
Oct 9, 2024
Merged

Conversation

oren-lava
Copy link
Collaborator

Description

Closes: #XXXX

Found a bug in the IPRPC pool distribution mechanism that ignored some of the leftover coins due to inappropriate error handling.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@oren-lava oren-lava self-assigned this Sep 8, 2024
Copy link

github-actions bot commented Sep 8, 2024

Test Results

2 207 tests  ±0   2 207 ✅ ±0   25m 23s ⏱️ -17s
  145 suites ±0       0 💤 ±0 
    7 files   ±0       0 ❌ ±0 

Results for commit d1fd83d. ± Comparison against base commit 130d0f1.

♻️ This comment has been updated with latest results.

x/rewards/keeper/iprpc.go Outdated Show resolved Hide resolved
@oren-lava oren-lava requested a review from Yaroms September 10, 2024 14:51
Yaroms
Yaroms previously approved these changes Sep 16, 2024
x/dualstaking/keeper/delegator_reward.go Outdated Show resolved Hide resolved
x/rewards/keeper/iprpc.go Outdated Show resolved Hide resolved
@oren-lava
Copy link
Collaborator Author

note that I added a small fix to the UnstakeEntryForce function here: ea74fac

@omerlavanet omerlavanet merged commit 0da0cd2 into main Oct 9, 2024
31 checks passed
@omerlavanet omerlavanet deleted the CNS-fix-iprpc-pook-distribution branch October 9, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants