Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CNS-fix-modify-cli #1647

Merged
merged 2 commits into from
Aug 25, 2024
Merged

fix: CNS-fix-modify-cli #1647

merged 2 commits into from
Aug 25, 2024

Conversation

Yaroms
Copy link
Collaborator

@Yaroms Yaroms commented Aug 23, 2024

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Copy link

github-actions bot commented Aug 23, 2024

Test Results

2 173 tests  +125   2 173 ✅ +128   25m 13s ⏱️ +53s
  145 suites +  2       0 💤 ±  0 
    7 files   +  1       0 ❌  -   3 

Results for commit 0d98df3. ± Comparison against base commit ea235a1.

♻️ This comment has been updated with latest results.

@omerlavanet omerlavanet merged commit 22bdee0 into main Aug 25, 2024
29 checks passed
@omerlavanet omerlavanet deleted the CNS-fix-modify-cli branch August 25, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants