Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: total-gas query fix #1641

Merged
merged 7 commits into from
Aug 26, 2024
Merged

fix: total-gas query fix #1641

merged 7 commits into from
Aug 26, 2024

Conversation

oren-lava
Copy link
Collaborator

Description

Closes: #XXXX

I've added proper support for the --height flag for the total-gas query


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@oren-lava oren-lava self-assigned this Aug 21, 2024
Copy link

github-actions bot commented Aug 21, 2024

Test Results

2 181 tests  ±0   2 181 ✅ ±0   26m 19s ⏱️ + 1m 23s
  145 suites ±0       0 💤 ±0 
    7 files   ±0       0 ❌ ±0 

Results for commit 75f5077. ± Comparison against base commit 802730b.

♻️ This comment has been updated with latest results.

utils/cli/multisend.go Outdated Show resolved Hide resolved
utils/cli/multisend.go Outdated Show resolved Hide resolved
utils/cli/multisend.go Show resolved Hide resolved
utils/cli/multisend.go Outdated Show resolved Hide resolved
@oren-lava oren-lava requested a review from omerlavanet August 25, 2024 11:05
@omerlavanet omerlavanet merged commit 359da07 into main Aug 26, 2024
29 checks passed
@omerlavanet omerlavanet deleted the CNS-total-gas-query-fix branch August 26, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants