Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PRT - offline spec support provider side with inheritance fix. #1640

Merged
merged 6 commits into from
Aug 28, 2024

Conversation

ranlavanet
Copy link
Collaborator

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Copy link

github-actions bot commented Aug 21, 2024

Test Results

2 181 tests  ±0   2 181 ✅ ±0   26m 17s ⏱️ + 2m 9s
  145 suites ±0       0 💤 ±0 
    7 files   ±0       0 ❌ ±0 

Results for commit 20a3f95. ± Comparison against base commit 21fb8a7.

♻️ This comment has been updated with latest results.

@ranlavanet ranlavanet self-assigned this Aug 21, 2024
protocol/rpcprovider/rpcprovider.go Outdated Show resolved Hide resolved
protocol/statetracker/state_tracker.go Show resolved Hide resolved
@ranlavanet ranlavanet requested a review from omerlavanet August 28, 2024 13:09
@omerlavanet omerlavanet merged commit 6ae8fce into main Aug 28, 2024
29 checks passed
@omerlavanet omerlavanet deleted the static-spec-provider-side branch August 28, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants