feat: PRT: Block Hash Cache #1623
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rpcconsumerserver
…RT-block-hash-cache
omerlavanet
requested changes
Aug 18, 2024
| func (rp *RelayProcessor) GetUserHeaders() []pairingtypes.Metadata { | ||
| rp.lock.RLock() | ||
| defer rp.lock.RUnlock() | ||
| return rp.userReturnHeaders |
There was a problem hiding this comment.
remove: headers are already inside the replies
| @@ -283,8 +363,15 @@ func (rp *RelayProcessor) checkEndProcessing(responsesCount int) bool { | |||
| return true | |||
| } | |||
| } | |||
|
|
|||
| usedProviders, ok := rp.usedProviders[rp.chainMessage.GetConcatenatedExtensions()] | |||
There was a problem hiding this comment.
this is a mistake, you check responses against the usedProviders object that can change, you need to manage responses for each used providers separately and check them
| } | ||
| } | ||
|
|
||
| var zeroK K |
There was a problem hiding this comment.
this is done by defining named returned values
|
|
||
| if err := decoder.Decode(&proposal); err != nil { | ||
| func GetASpec(specIndex, getToTopMostPath string, ctxArg *sdk.Context, keeper *keeper.Keeper) (specRet spectypes.Spec, err error) { |
There was a problem hiding this comment.
move this from testUtils to utils if this is used in production code
| @@ -118,7 +124,17 @@ func (cst *ConsumerStateTracker) TxConflictDetection(ctx context.Context, finali | |||
| return err | |||
| } | |||
|
|
|||
| func (cst *ConsumerStateTracker) RegisterForSpecUpdates(ctx context.Context, specUpdatable updaters.SpecUpdatable, endpoint lavasession.RPCEndpoint) error { | |||
| func (cst *ConsumerStateTracker) RegisterForSpecUpdates(ctx context.Context, specUpdatable updaters.SpecUpdatable, endpoint lavasession.RPCEndpoint, offlineSpecOptions *OfflineSpecOptions) error { | |||
There was a problem hiding this comment.
no need for this, just call setSpec on the updatable instead of calling this function by the caller
|
DEPRECATED AFTER REDESIGN |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changemainbranchReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...