fix: unlink cache unix socket #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When deploying the cache service on a machine that already had one running the error:
bind failed. Error: Address already in use. Unlike TCP the sock file must be cleaned out of the filesystem after service exit.Using
syscall.unlinkbefore creating the new unix socket makes sure that the filesystem is clean when creating a new one.This also makes sure that no matter how the program existed the socket will always be deleted.
Also using
SplitHostPortandResolveUnixAddrto properly parse and initiate the unix socket.How this was tested?
Aside from running locally, this was tested by coping the PR artifact to testing server, restarting the cache, then restarting it again and making sure IPRPC can reach it.
Author Checklist