New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: CNS 930: new epoch payments objects #1335

Merged

Yaroms merged 39 commits into main from CNS-930-begin-block-may-take-too-long

Apr 3, 2024

Collaborator

oren-lava commented Mar 26, 2024

Replaced the old payment objects with new efficient ones (see epoch_cu.go head comment for more details).

Migrator checked on both a new and testnet-synced nodes.

oren-lava added 11 commits

March 20, 2024 16:59


          CNS-930: define proto of new epoch cu structs

eedddfe


          CNS-930: create epoch CU objects + basic unit tests

209b607


          CNS-930: updated epoch CU objects implementation


          CNS-930: added check for valid key when decoding

d9f7a54


          CNS-930: updated genesis with new epoch cu objects

7f3d3dd


          CNS-930: added chain ID to epoch CU objects

cec2043


          CNS-930: change the epoch payments mechanism to the new one

47eb662


          CNS-930: add fixed time work around for time dependent unit tests

5a8b1f1


          CNS-930: added provider epoch CU query and updated E2E

46c69de


          CNS-930: migrator

7a65221


          Merge branch 'main' into CNS-930-begin-block-may-take-too-long

bc04778

oren-lava requested review from omerlavanet and Yaroms

March 26, 2024 16:52

oren-lava self-assigned this

github-actions bot added Type: Build Team:Consensus C:x/pairing C:x/subscription C:proto Type: Proto labels

oren-lava changed the title ~~feat: CNS 930 begin block may take too long~~ feat: CNS 930: new epoch payments objects


          CNS-930: lint fixes

e820d36

Yaroms reviewed

View reviewed changes

testutil/e2e/protocolE2E.go Outdated Show resolved Hide resolved

Yaroms reviewed

View reviewed changes

x/pairing/client/cli/query_provider_epoch_cu.go Outdated Show resolved Hide resolved

Yaroms reviewed

View reviewed changes

proto/lavanet/lava/pairing/genesis.proto Outdated Show resolved Hide resolved

Yaroms reviewed

View reviewed changes

x/pairing/genesis.go Outdated Show resolved Hide resolved

Yaroms reviewed

View reviewed changes

x/pairing/genesis.go Outdated Show resolved Hide resolved

Yaroms reviewed

View reviewed changes

x/pairing/genesis.go Outdated Show resolved Hide resolved

Yaroms reviewed

View reviewed changes

x/pairing/keeper/epoch_cu.go Outdated Show resolved Hide resolved

Yaroms reviewed

View reviewed changes

x/pairing/keeper/epoch_cu.go Outdated Show resolved Hide resolved

oren-lava added 4 commits

March 28, 2024 12:05


          CNS-930: small fix

778c749


          CNS-930: lint

817e18b


          Merge branch 'main' into CNS-930-begin-block-may-take-too-long

d190137


          CNS-930: fix protocol proto script

aa3c7b9

github-actions bot added the Team:Protocol label


          updated

ec2852e

Yaroms reviewed

View reviewed changes

x/pairing/keeper/epoch_payment.go Outdated Show resolved Hide resolved

Yaroms reviewed

View reviewed changes

x/pairing/keeper/unresponsive_provider.go Outdated Show resolved Hide resolved

oren-lava added 3 commits

March 28, 2024 15:09


          Revert "updated"

d5cd7b8

This reverts commit ec2852e.


          CNS-930: change GetAllProviderConsumerEpochCu return type

a04a6b5


          CNS-930: update unresponsive count to be efficient

04683ca

Yaroms reviewed

View reviewed changes

x/pairing/keeper/fixation_test.go Show resolved Hide resolved

Yaroms reviewed

View reviewed changes

x/pairing/keeper/epoch_cu.go Outdated Show resolved Hide resolved

Yaroms reviewed

View reviewed changes

x/pairing/keeper/epoch_cu.go Outdated Show resolved Hide resolved

Yaroms reviewed

View reviewed changes

x/pairing/keeper/unresponsive_provider.go Outdated Show resolved Hide resolved

Yaroms reviewed

View reviewed changes

x/pairing/keeper/unresponsive_provider.go Outdated Show resolved Hide resolved

oren-lava added 4 commits

April 1, 2024 16:07


          CNS-930: small PR fix

faea0af


          CNS-930: another small PR fix

51c70a2


          CNS-930: sort complainedProviders keys

60bdeb0


          CNS-930: small PR fix

23ed82a

Collaborator

Yaroms commented Apr 2, 2024

also, please encode the epoch with something like this and not string

lava/x/fixationstore/types/keys.go

Line 25 in dbe9e2f

func EncodeBlockAndKey(block uint64, key []byte) []byte {

if in the future we will want it sorted we will need this

Yarom Swisa and others added 6 commits

April 3, 2024 12:18


          make a object just for complainer cu

8a92426


          encode uint instead of convert to string

d8a16e9


          fix iterators

62bd971


          Merge branch 'main' into CNS-930-begin-block-may-take-too-long

817f645


          validate genesis

c5127a4


          Merge branch 'CNS-930-begin-block-may-take-too-long' of github.com:la…

2895ff6

…vanet/lava into CNS-930-begin-block-may-take-too-long

Yaroms approved these changes

View reviewed changes

Yaroms merged commit c665e6a into main

27 checks passed

Yaroms deleted the CNS-930-begin-block-may-take-too-long branch

April 3, 2024 11:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C:proto C:x/pairing C:x/subscription Team:Consensus Team:Protocol Type: Build Type: Proto