Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added folded_compilation option in SolverConfig #270

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Conversation

ymeng-git
Copy link
Contributor

Issue Number:

Objective of pull request:

"folded_compilation" is added as a boolean option in SolverConfig with default value to False. This is to ease the compilation of parallel QUBO solver demo-ing on big systems.

When it's set to True by a user, all internal SolutionFinder(s) will be compiled based on folded view to speed up the compilation.

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (pyb) passes locally
  • Build tests (pyb -E unit) or (python -m unittest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

Copy link
Contributor

@phstratmann phstratmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working to enable this feature!
Just a minor comment, then this can be merged in my view.

@ymeng-git ymeng-git merged commit a03b700 into main Oct 19, 2023
3 checks passed
@ymeng-git
Copy link
Contributor Author

For multi-instance workload, setting (SolverConfig.folded_compilation = True) will automatically enable the folded compilation in Lava and Lava-loihi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants