Warning on battery notPresent #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darxriggs
reviewed
Apr 6, 2021
| @@ -189,6 +189,8 @@ sub check { | |||
| $self->add_info(sprintf 'controller accelerator battery is %s', | |||
| $self->{cpqDaAccelBattery}); | |||
| if ($self->{cpqDaAccelBattery} eq "notPresent") { | |||
| # permenently disabled battery return as notPresent even when it is disabled because of a faulty battery | |||
There was a problem hiding this comment.
There is a typo. It should read permanently.
|
What if there is no battery on purpose? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check currently doesn't trigger a warning on the battery accelerator being "notPresent". The battery status will be "notPresent" if the cache is permanently disabled due to a faulty battery being present.
I have also added in the changes from #16 for the name change