-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to run on newer versions of Java #329
base: master
Are you sure you want to change the base?
Conversation
thanks for implementing this! |
the branch doesn't work for me when uploading the website:
|
@eljojo What version of Java are you using? Run |
You are a legend!!!!!! 👏👏👏👏👏👏👏 |
@nabilfreeman Thanks! What version |
@yanokwa Since this project is no longer maintained, what if you create a new release from your fork? Something like s3_website_2 or s3_website_plus, so future pull requests and gem releases could continue there. |
@flipacholas I don't have the skills or time to lead a fork. I've filed a ticket at #330 to we can find someone who can. |
FYI, it does not work using latest JDK on macOS 10.15.2.
|
Here's the explanation for the previous error:
A simple solution is to upgrade |
Upgrade to run on newer versions of Java laurilehmijoki#329
Fixes #300
./sbt test
.java -jar target/scala-2.11/s3_website.jar
without a Java error in a Java 1.8, Java 11, and Java 12 environment. No other detailed tests (e.g., uploading to S3) was performed.bin/s3_website
itself to Java 11 because Java 1.8 is mostly deprecated. I Googled for version numbers and did not actually verify those package names are correct on a machine.build.properties
to do this did not work.