Desktop: Resolves #11600: OneNote imported notes have broken links when there are chineses characters on link

[pedr]

Should be merged after #11598
Resolves #11600

Summary

Links from notes imported from OneNote sometimes would break and not find the final delimiter when being rendered to HTML, but I could never understand why that happens, I think this is the reason:

First how the renderer for the rich text works, it has 3 parts:

• one is the text content that is going to be displayed
• second are the styles that are going to be applied
• third is an index of where the break point of each style should be

Example

OneNoteConverter:  Parts: [
    "Tips from a Pro: Using Trees for Dramatic Landscape Photography",
    ".one#Tips%20from%20a%20Pro%20Using%20Trees%20for%20Dramatic%20Landscape%20Photography&sec
    "风景",
    "\u{fddf}HYPERLINK \"onenote:https://d.docs.live.net/c8d3bbab7f1acf3a/Documents/Photograph
], Indices: [
    83,
    85,
    272,
], Styles: [
    ParagraphStyling {
        charset: Some(
            Ansi,
        ),
        bold: false,
        italic: false,
        underline: false,
        strikethrough: false,
        superscript: false,
        subscript: false,
        font: None,
        font_size: None,
        font_color: None,
        highlight: None,
        next_style: None,
        style_id: None,
        paragraph_alignment: None,
        paragraph_space_before: None,
        paragraph_space_after: None,
        paragraph_line_spacing_exact: None,
        language_code: Some(
            2052,
        ),
        math_formatting: false,
        hyperlink: true,
    },
    ParagraphStyling {
        charset: Some(
            Gb2312,
        ),
        bold: false,
        italic: false,
        underline: false,
        strikethrough: false,
        superscript: false,
        subscript: false,
        font: Some(
            "Microsoft YaHei",
        ),
        font_size: None,
        font_color: None,
        highlight: None,
        next_style: None,
        style_id: None,
        paragraph_alignment: None,
        paragraph_space_before: None,
        paragraph_space_after: None,
        paragraph_line_spacing_exact: None,
        language_code: Some(
            2052,
        ),
        math_formatting: false,
        hyperlink: true,
    },
    ParagraphStyling {
        charset: Some(
            Ansi,
        ),
        bold: false,
        italic: false,
        underline: false,
        strikethrough: false,
        superscript: false,
        subscript: false,
        font: None,
        font_size: None,
        font_color: None,
        highlight: None,
        next_style: None,
        style_id: None,
        paragraph_alignment: None,
        paragraph_space_before: None,
        paragraph_space_after: None,
        paragraph_line_spacing_exact: None,
        language_code: Some(
            2052,
        ),
        math_formatting: false,
        hyperlink: true,
    },
    ParagraphStyling {
        charset: Some(
            Ansi,
        ),
        bold: false,
        italic: false,
        underline: false,
        strikethrough: false,
        superscript: false,
        subscript: false,
        font: None,
        font_size: None,
        font_color: None,
        highlight: None,
        next_style: None,
        style_id: None,
        paragraph_alignment: None,
        paragraph_space_before: None,
        paragraph_space_after: None,
        paragraph_line_spacing_exact: None,
        language_code: Some(
            1033,
        ),
        math_formatting: false,
        hyperlink: true,
    },
]

In the current implementation wasn't implemented like this, it was assumed that the index-to-styles would always match, meaning that content that should be rendered as (ignore line breaks, included to help reading):

<a href="onenote:https://d.docs.live.net/c8d3bbab7f1acf3a/Documents/Photography/风景
  .one#Tips%20from%20a%20Pro%20Using%20Trees%20for%20Dramatic%20Landscape%20Photography
  &section-id={262ADDFB-A4DC-4453-A239-0024D6769962}
  &page-id={88D803A5-4F43-48D4-9B16-4C024F5787DC}&end" style=""
>
  Tips from a Pro: Using Trees for Dramatic Landscape Photography
</a>

Would be rendered as

<a href="onenote:https://d.docs.live.net/c8d3bbab7f1acf3a/Documents/Photography/" style"">
  风景.one#Tips%20from%20a%20Pro%20Using%20Trees%20for%20Dramatic%20Landscape%20Photography
  &section-id={262ADDFB-A4DC-4453-A239-0024D6769962}
  &page-id={88D803A5-4F43-48D4-9B16-4C024F5787DC}
  &end"Tips from a Pro: Using Trees for Dramatic Landscape Photography
</a>

It is not entirely clear to me why that happens, but looking at the example above it is possible to see that a different charset is used for the two Chinese characters (index 83 and 85).

I don't know why that would be necessary, but this solution should fix the issue.

Testing

I added an automated test case that this PR is based on