Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Fixes #11445: Link watched files to the current window #11590

Conversation

personalizedrefrigerator
Copy link
Collaborator

Summary

Before this pull request, all watched attachments were unwatched when the main window switched notes. This pull request instead links watched notes to the window from which they were opened.

Fixes #11445.

Note

With this change, the "watching for changes" notification lists attachments being watched for changes by the current window.

Testing plan

Desktop (Fedora Linux):

  1. Attach drawings to two different notes ("note A" and "note B").
  2. Open note A in the main window and note B in a secondary window.
  3. Right-click > open the image in note A.
  4. Verify that Joplin states that the image is being watched.
  5. Make a change to the image externally.
  6. Verify that the Markdown preview in note A updates to show the changed image.
  7. Right-click > open the image in note B from the secondary window.
  8. Make a change.
  9. Verify that the Markdown preview in note B updates to show the changed image.
  10. In the main window, switch to a different note.
  11. Verify that the main window no longer states that the image from note A is being watched.
  12. Verify that the secondary window still states that the image from note B is being watched.
  13. Make a change to the image from note A externally.
  14. Switch back to note A.
  15. Verify that the image has not updated in Joplin. (It should no longer be watched).
  16. Make a change to the image from note B externally.
  17. Verify that the image has updated. (It should still be watched).
  18. Close the secondary window.
  19. Make a change to the image from note B externally.
  20. Verify that the image has not updated. (It should no longer be watched).

@laurent22 laurent22 merged commit ac154ee into laurent22:dev Jan 6, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple window support: Watched files are linked to the note open in the main window
2 participants