Skip to content
This repository has been archived by the owner on Jul 24, 2023. It is now read-only.

Remove @memorizer #6

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Remove @memorizer #6

wants to merge 4 commits into from

Conversation

ninjinkun
Copy link
Contributor

@ninjinkun ninjinkun commented Jun 7, 2022 •
edited
Loading

I removed @memoizer and moved regex initialization to the global scope. This is because:

  1. These regexes are called at least once anyway
    1. It means the computational complexity of both @memoizer and global variables are equal
  2. @memoizer isn't related to the main purpose of this module. It's redundant

@ninjinkun ninjinkun requested a review from okajimad June 7, 2022 11:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@okajimad okajimad Awaiting requested review from okajimad

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ninjinkun