Misc touch up #8
Merged
+12
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intake dev mode runs on 8080 by default, so let's move this to 8081
... with java.level.
In general, this is a bad practice, but in this specific case, as I implied in the comment, this is as intended. We didn't want any errors to get in the way of people's builds.
Apache HttpClient is designed to allow entity to report Content-Encoding header on its own, so no need to set this by ourselves. It leaks abstractions.
Assuming this configuration is intended for the use during the development time, we can have Maven auto-insert the right value.
Konboi
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit messages of the three commits for their respective motivations.