Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix load error #7

Closed
wants to merge 2 commits into from
Closed

Fix load error #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb8b2d3
update versions
Konboi Oct 28, 2024
d61d0ae
update jenkins version to fix loading error
Konboi Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<parent>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>plugin</artifactId>
<version>4.12</version>
<version>4.63</version>
<relativePath />
</parent>
<artifactId>launchable</artifactId>
Expand All @@ -16,8 +16,8 @@
<revision>1.0</revision>
<changelist>-SNAPSHOT</changelist>
<gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo>
<jenkins.version>2.222.4</jenkins.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We intentionally depend on older version of Jenkins in order to maintain compatible with a wide range of Jenkins. There's nothing in this plugin that requires new version of Jenkins, so it's important to stick to the current base Jenkins version.

<java.level>8</java.level>
<jenkins.version>2.401.3</jenkins.version>
<java.level>11</java.level>
<no-test-jar>false</no-test-jar>
<configuration-as-code.version>1.44</configuration-as-code.version>
</properties>
Expand All @@ -26,11 +26,24 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.8.1</version>
<configuration>
<source>1.8</source>
<target>1.8</target>
<source>11</source>
<target>11</target>
Copy link
Contributor Author

@Konboi Konboi Oct 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use Java v11?

</configuration>
</plugin>
<plugin>
<groupId>org.kohsuke</groupId>
<artifactId>access-modifier-checker</artifactId>
<version>1.23</version> <!-- Replace with the latest stable version -->
<executions>
<execution>
<goals>
<goal>enforce</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>
<licenses>
Expand Down Expand Up @@ -65,7 +78,6 @@
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>junit</artifactId>
<version>1.41</version>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
Expand Down Expand Up @@ -171,15 +183,14 @@
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>jackson2-api</artifactId>
<version>2.11.3</version>
</dependency>
</dependencies>
<dependencyManagement>
<dependencies>
<dependency>
<groupId>io.jenkins.tools.bom</groupId>
<artifactId>bom-2.222.x</artifactId>
<version>15</version>
<artifactId>bom-2.361.x</artifactId>
<version>1823.v3c2a_345def3a</version>
<scope>import</scope>
<type>pom</type>
</dependency>
Expand Down