Fix some points to integrate #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Konboi
commented
Oct 25, 2024
| if (endpoint==null) { | ||
| endpoint = DEFAULT_UPLOAD_URL; | ||
| } | ||
| var hc = new HttpPost(endpoint); | ||
| HttpPost hc = new HttpPost(String.format("%s/intake/organizations/%s/workspaces/%s/events/jenkins", endpoint, orgWs.getOrganization(), orgWs.getWorkspace())); |
There was a problem hiding this comment.
I'm not familiar with assembling URL part. Can I use String.format?
|
|
||
| var builder = MultipartEntityBuilder.create(); |
There was a problem hiding this comment.
Not to use Java 10 idiom
| builder.addTextBody("metadata", properties.build().toString(), ContentType.APPLICATION_JSON); | ||
| builder.addBinaryBody("file", report, ContentType.APPLICATION_XML, "junitResult.xml"); | ||
|
|
||
| hc.setEntity(new GzipCompressingEntity(builder.build())); | ||
| hc.addHeader("Authorization", "Bearer " + apiKey.getPlainText()); | ||
| hc.setHeader(HttpHeaders.CONTENT_ENCODING, "gzip"); |
There was a problem hiding this comment.
We talked it this part directly, it seems server side can't handle compressed request correctly.
kohsuke
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
var. Thus, fixed it