fix: bring back metrics

latticexyz · Feb 27, 2024 · f486863 · f486863
1 parent 0bcd84b
commit f486863
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/op-node/metrics/metrics.go b/op-node/metrics/metrics.go
@@ -10,8 +10,8 @@ import (
 	"github.com/ethereum/go-ethereum/params"
 
 	"github.com/ethereum-optimism/optimism/op-node/p2p/store"
+	plasma "github.com/ethereum-optimism/optimism/op-plasma"
 
-	// plasma "github.com/ethereum-optimism/optimism/op-plasma"
 	ophttp "github.com/ethereum-optimism/optimism/op-service/httputil"
 	"github.com/ethereum-optimism/optimism/op-service/metrics"
 
@@ -124,7 +124,7 @@ type Metrics struct {
 
 	TransactionsSequencedTotal prometheus.Counter
 
-	// PlasmaMetrics plasma.Metricer
+	PlasmaMetrics plasma.Metricer
 
 	// Channel Bank Metrics
 	headChannelOpenedEvent *metrics.Event
@@ -388,7 +388,7 @@ func NewMetrics(procName string) *Metrics {
 			"required",
 		}),
 
-		// PlasmaMetrics: plasma.MakeMetrics(ns, factory),
+		PlasmaMetrics: plasma.MakeMetrics(ns, factory),
 
 		registry: registry,
 		factory:  factory,

diff --git a/op-node/node/node.go b/op-node/node/node.go
@@ -393,7 +393,7 @@ func (n *OpNode) initL2(ctx context.Context, cfg *Config, snapshotLog log.Logger
 	if cfg.Plasma.Enabled && err != nil {
 		return fmt.Errorf("failed to get plasma config: %w", err)
 	}
-	plasmaDA := plasma.NewPlasmaDA(n.log, cfg.Plasma, rpCfg, n.l1Source, &plasma.NoopMetrics{})
+	plasmaDA := plasma.NewPlasmaDA(n.log, cfg.Plasma, rpCfg, n.l1Source, n.metrics.PlasmaMetrics)
 	if cfg.Plasma.Enabled {
 		n.log.Info("Plasma DA enabled", "da_server", cfg.Plasma.DAServerURL)
 		// Plasma takes control of the engine finalization signal callback only when enabled