-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use new config #2483
feat: use new config #2483
Conversation
🦋 Changeset detectedLatest commit: 0d0bdb1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
240e9f2
to
e0a5bbd
Compare
e0a5bbd
to
665e81e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isn't used, was moved up a directory but this never got removed
bc8bfda
to
0d0bdb1
Compare
createdAt: "uint256", | ||
completedAt: "uint256", | ||
description: "string", | ||
}, | ||
key: ["id"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OOC it is possible to use shorthand here?
Or alternatively you could reduce the diff by keeping the key
name
schema: { | ||
id: "bytes32", | ||
createdAt: "uint256", | ||
completedAt: "uint256", | ||
description: "string", | ||
}, | ||
key: ["id"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
schema: { | |
id: "bytes32", | |
createdAt: "uint256", | |
completedAt: "uint256", | |
description: "string", | |
}, | |
key: ["id"], | |
id: "bytes32", | |
createdAt: "uint256", | |
completedAt: "uint256", | |
description: "string", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not blocking at all though
taking another stab at #2470