feat(world-modules): register delegation with signature

[yonadaaa]

Addresses #2383

This PR adds a new registerDelegationWithSignature function to the World:

function registerDelegationWithSignature(
  address delegatee,
  ResourceId delegationControlId,
  bytes memory initCallData,
  address delegator,
  bytes memory signature
) public onlyDelegatecall;

and a new UserDelegationNonces table, to prevent reply attacks:

UserDelegationNonces: {
  schema: { delegator: "address", nonce: "uint256" },
  key: ["delegator"],
}

Anyone can call registerDelegationWithSignature to register a delegation for delegator, provided that the given EIP-1271 signature is valid (ie. was signed for the same contract address, chain ID, nonce, delegation details etc.)

If the signature is valid, the delegation is created and the nonce is incremented.

[changeset-bot]

🦋 Changeset detected

Latest commit: 25ed862

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages

Name	Type
@latticexyz/cli	Patch
@latticexyz/world-modules	Patch
@latticexyz/world	Patch
@latticexyz/dev-tools	Patch
@latticexyz/store-sync	Patch
@latticexyz/store-indexer	Patch
@latticexyz/abi-ts	Patch
@latticexyz/block-logs-stream	Patch
@latticexyz/common	Patch
@latticexyz/config	Patch
create-mud	Patch
@latticexyz/faucet	Patch
@latticexyz/gas-report	Patch
@latticexyz/protocol-parser	Patch
@latticexyz/query	Patch
@latticexyz/react	Patch
@latticexyz/recs	Patch
@latticexyz/schema-type	Patch
@latticexyz/services	Patch
solhint-config-mud	Patch
solhint-plugin-mud	Patch
@latticexyz/store	Patch
@latticexyz/utils	Patch
mock-game-contracts	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[alvrs]

Suggested change

	revert Module_RootInstallNotSupported();
	revert Module_NonRootInstallNotSupported();

[alvrs]

I think InvalidSignature would be more descriptive here, since the signer would not match the delegator if any piece of the signature doesn't match (delegatee, nonce, etc)

Suggested change

	revert InvalidSigner(delegator, delegatee);
	revert InvalidSignature(signer);

[alvrs]

since this file exports a single constant called delegationWithSignatureTypes we should call the file the same

[alvrs]

I want to really make sure it's clear this module is not meant for stable usage yet and we will remove it in the near future once it's audited and moved into the World. Should we rename it to Unstable_DelegationWithSignatureSystem for now?