Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(store,world): prefix errors with library/contract name #1568

Merged
merged 12 commits into from
Sep 22, 2023
Merged

refactor(store,world): prefix errors with library/contract name #1568

merged 12 commits into from
Sep 22, 2023

Conversation

alvrs
Copy link
Member

@alvrs alvrs commented Sep 21, 2023 •
edited by holic
Loading

partially fixes #1126

@changeset-bot
Copy link

changeset-bot bot commented Sep 21, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 407c784

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@latticexyz/store Patch
@latticexyz/world Patch
@latticexyz/cli Patch
@latticexyz/dev-tools Patch
@latticexyz/react Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/ecs-browser Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/network Patch
@latticexyz/noise Patch
@latticexyz/phaserx Patch
@latticexyz/protocol-parser Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
@latticexyz/services Patch
@latticexyz/solecs Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/std-client Patch
@latticexyz/std-contracts Patch
@latticexyz/store-cache Patch
@latticexyz/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alvrs alvrs changed the title rea refactor(store,world): prefix errors with library/contract name Sep 21, 2023
@alvrs
Copy link
Member Author

alvrs commented Sep 21, 2023 •
edited
Loading

should we rename store events to Store_SetRecord etc for consistency?

Edit: I think we should, and how is the last chance we can. Followup PR is here: #1577

@alvrs alvrs marked this pull request as ready for review September 21, 2023 22:07
@alvrs alvrs requested review from dk1a and holic as code owners September 21, 2023 22:07
holic
holic reviewed Sep 22, 2023
View reviewed changes
packages/world/src/interfaces/IModule.sol Outdated
@@ -10,7 +10,7 @@ bytes4 constant MODULE_INTERFACE_ID = IModule.getName.selector ^
ERC165_INTERFACE_ID;

interface IModule is IERC165 {
error RootInstallModeNotSupported();
error RootInstallNotSupported();
error NonRootInstallNotSupported();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should these be World_ or Module_ prefixed?

holic
holic previously approved these changes Sep 22, 2023
View reviewed changes
alvrs
alvrs commented Sep 22, 2023
View reviewed changes
Copy link
Member Author

@alvrs alvrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@alvrs alvrs merged commit d087892 into main Sep 22, 2023
9 checks passed
@alvrs alvrs deleted the alvrs/eventnames branch September 22, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holic holic holic left review comments

@dk1a dk1a Awaiting requested review from dk1a

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prefix all events and errors with library/contract name
2 participants
@alvrs @holic