Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(world): move codegen files #1537

Closed
wants to merge 1 commit into from
Closed

Conversation

holic
Copy link
Member

@holic holic commented Sep 18, 2023

when I was working on #1318, some files got left around because world doesn't use a codegen dir, so it was harder to identify+clean up files

I still don't love the approach, maybe mostly because of how we do module codegen? I think that would be fixed if each module had its own mud config?

in the meantime, instead of all the codegen being lumped together, could customize each table to have its own codegen dir within its respective module?

@changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2023

⚠️ No Changeset found

Latest commit: 5d54afa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@holic holic changed the title refactor(world): move codegen refactor(world): move codegen files Sep 18, 2023
@alvrs alvrs added this to the Contracts stable milestone Sep 21, 2023
@alvrs alvrs self-assigned this Sep 21, 2023
@alvrs
Copy link
Member

alvrs commented Sep 25, 2023

closing in favor of #1592

@alvrs alvrs closed this Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants