feat(store,world): move hooks to bit flags #1527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2545542 The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
holic
changed the title
alvrs
reviewed
Sep 17, 2023
Comment on lines
-55
to
+56
| function isEnabled(Hook self, uint8 hookType) internal pure returns (bool) { | ||
| // Pick the bitmap encoded in the rightmost byte from the hook and check if the bit at the given hook type is set | ||
| return (getBitmap(self) & (1 << uint8(hookType))) != 0; | ||
| function isEnabled(Hook self, uint8 hookTypes) internal pure returns (bool) { | ||
| return (getBitmap(self) & hookTypes) == hookTypes; |
alvrs
reviewed
Sep 17, 2023
|
|
||
| uint8 constant BEFORE_SET_RECORD = 1 << 0; | ||
| uint8 constant AFTER_SET_RECORD = 1 << 1; | ||
| // TODO: do we need to differentiate between static and dynamic set field? |
There was a problem hiding this comment.
cross posting here from discord for context: the "set field" hook is soon replaced with a "splice" hook (see #1510)
alvrs
approved these changes
Sep 17, 2023
don't think this will be necessary since we'll only have 6 hooks (before/after set, splice, delete) Edit: it's 8 (before/after set, splice static, splice dynamic, delete) but still fits in 8 bit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1459
TODO: