fix(explorer): format default sql query (#3363)

latticexyz · Nov 6, 2024 · 0facee0 · 0facee0
1 parent 3168f1f
commit 0facee0
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 377 deletions.
diff --git a/.changeset/hip-spies-wave.md b/.changeset/hip-spies-wave.md
@@ -0,0 +1,5 @@
+---
+"@latticexyz/explorer": patch
+---
+
+When accessing a new table in Explore tab, the SQL editor now encloses all column names in double quotes in order to prevent invalid queries.
diff --git a/packages/explorer/src/app/(explorer)/[chainName]/worlds/[worldAddress]/explore/Explorer.tsx b/packages/explorer/src/app/(explorer)/[chainName]/worlds/[worldAddress]/explore/Explorer.tsx
@@ -12,7 +12,6 @@ import { indexerForChainId } from "../../../../utils/indexerForChainId";
 import { SQLEditor } from "./SQLEditor";
 import { TableSelector } from "./TableSelector";
 import { TablesViewer } from "./TablesViewer";
-import { postgresKeywords } from "./consts";
 
 export function Explorer() {
   const { worldAddress } = useParams();
@@ -30,12 +29,10 @@ export function Explorer() {
       const tableName = constructTableName(table, worldAddress as Hex, chainId);
 
       if (indexer.type === "sqlite") {
-        setQuery(`SELECT * FROM "${tableName}"`);
+        setQuery(`SELECT * FROM "${tableName}";`);
       } else {
-        const columns = Object.keys(table.schema).map((column) =>
-          postgresKeywords.includes(column.toLowerCase()) ? `"${column}"` : column,
-        );
-        setQuery(`SELECT ${columns.join(", ")} FROM ${tableName}`);
+        const columns = Object.keys(table.schema).map((column) => `"${column}"`);
+        setQuery(`SELECT ${columns.join(", ")} FROM ${tableName};`);
       }
     }
   }, [chainId, setQuery, selectedTableId, table, worldAddress, prevSelectedTableId, query, indexer.type]);