fix for #1591 #1592
Merged
fix for #1591 #1592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankMittelbach
requested review from
davidcarlisle,
josephwright and
car222222
davidcarlisle
approved these changes
Dec 22, 2024
Co-authored-by: Yukai Chou <[email protected]>
Skillmon
reviewed
Dec 22, 2024
Comment on lines
+601
to
+606
| \group_begin: | ||
| \exp_after:wN | ||
| \group_end: | ||
| \exp_after:wN | ||
| \@@_patch_cmd_or_delay:Nnn | ||
| \cs:w #2\cs_end: |
There was a problem hiding this comment.
Maybe use \group_begin: \exp_args:NNc \group_end: instead of the \exp_after:wN chain.
There was a problem hiding this comment.
I'm not sure it is more readable this way (given that it is a hack anyway)
josephwright
approved these changes
Dec 24, 2024
car222222
reviewed
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal housekeeping
Status of pull request
Checklist of required changes before merge will be approved
\changesentries in source includedchanges.txtupdatedltnewsX.tex(and/orlatexchanges.tex) updated