Gh1585 allowing \fpeval in array preamble #1586
Open
+105
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've done some minimal adjustment to longtable, to make it work with the change in array. It could probably be simplified by using @startpbox@preamble and then keeping @startpbox for the action rather than having @startpbox and @startpboxaction with the same top-level definitions. But that might mean more checking on other packages how they use @startpbox and @mkpream. So I'm not sure it is worth the effort. @davidcarlisle does it looks okay to you? |
Skillmon
reviewed
Dec 19, 2024
FrankMittelbach
requested review from
davidcarlisle
and removed request for
davidcarlisle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal housekeeping
Status of pull request
Ready to merge
Checklist of required changes before merge will be approved
\changesentries in source includedchanges.txtupdatedltnewsX.tex(and/orlatexchanges.tex) updatedThere is one surprising test suite diff for tagging-002-longtable. That needs checking and verification.