Skip to content

Commit

Permalink
rollback tests and documentation for #1581
Browse files Browse the repository at this point in the history
  • Loading branch information
FrankMittelbach committed Dec 11, 2024
1 parent 24743e3 commit 0e87160
Show file tree
Hide file tree
Showing 44 changed files with 400 additions and 36 deletions.
6 changes: 6 additions & 0 deletions base/changes.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@ to completeness or accuracy and it contains some references to files that are
not part of the distribution.
================================================================================

2024-12-11 Frank Mittelbach <[email protected]>

* ltfssaxes.dtx (subsection{Mapping rules for shape combinations}):
Add ssc shape change rules (gh/1581)
Also took the opportunity to provide better fallbacks for sw shape.

2024-12-10 Yukai Chou <[email protected]>
* ltxref.dtx (subsection{Cross Referencing})
Replace \@tempa with \reserved@a in \Ref (gh/1579)
Expand Down
22 changes: 22 additions & 0 deletions base/doc/ltnews41.tex
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,28 @@ \subsection{Logging text command and symbol declarations}
%
\githubissue{1242}

\subsection{Supporting the \texttt{ssc} and \texttt{sw} shapes}

The \texttt{ssc} shape (spaced small capitals) is supported in
\LaTeX{} through the commands \cs{sscshape} and \cs{textssc}. However,
until this release there where no font shape change rules defined for
this admittely seldom available shape, so that
\begin{verbatim}
\sscshape\itshape
\end{verbatim}
changed unconditionally to \texttt{it} (italics) rather than to
\texttt{sscit} (spaced small italic capitals). Thanks to Michael
Ummels the missing declarations have now been added so that shape
changes in font families that support spaced small capitals work
properly.

At the same time we took the opportunity to improve the fallbacks for
the \texttt{sw} (swash) shapes, which are accessible through the
commands \cs{swshape} or \cs{textsw}. If an \texttt{sw} combination is
not available, the rules now try to replace \texttt{sw} with
\texttt{it} rather than falling back to \texttt{n}.
%
\githubissue{1581}


\section{Bug fixes}
Expand Down
275 changes: 241 additions & 34 deletions base/ltfssaxes.dtx

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions base/testfiles-lthooks/lthooks-rollback-args.tlg
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,9 @@ LaTeX Info: Redefining \ulcshape on input line ....
LaTeX Info: Redefining \swshape on input line ....
LaTeX Info: Redefining \sscshape on input line ....
Already applied: [....-..-..] Font shape change rules on input line ....
Skipping: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Rules for ssc and sw on input line ....
Already applied: [....-..-..] Rules for ssc and sw on input line ....
Skipping: [....-..-..] Font shape change on input line ....
Applying: [....-..-..] Font shape change on input line ....
LaTeX Info: Redefining \fontshape on input line ....
Expand Down
3 changes: 3 additions & 0 deletions base/testfiles/github-0479-often.luatex.tlg
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,9 @@ LaTeX Info: Redefining \ulcshape on input line ....
LaTeX Info: Redefining \swshape on input line ....
LaTeX Info: Redefining \sscshape on input line ....
Already applied: [....-..-..] Font shape change rules on input line ....
Skipping: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Rules for ssc and sw on input line ....
Already applied: [....-..-..] Rules for ssc and sw on input line ....
Skipping: [....-..-..] Font shape change on input line ....
Applying: [....-..-..] Font shape change on input line ....
LaTeX Info: Redefining \fontshape on input line ....
Expand Down
3 changes: 3 additions & 0 deletions base/testfiles/github-0479-often.tlg
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,9 @@ LaTeX Info: Redefining \ulcshape on input line ....
LaTeX Info: Redefining \swshape on input line ....
LaTeX Info: Redefining \sscshape on input line ....
Already applied: [....-..-..] Font shape change rules on input line ....
Skipping: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Rules for ssc and sw on input line ....
Already applied: [....-..-..] Rules for ssc and sw on input line ....
Skipping: [....-..-..] Font shape change on input line ....
Applying: [....-..-..] Font shape change on input line ....
LaTeX Info: Redefining \fontshape on input line ....
Expand Down
3 changes: 3 additions & 0 deletions base/testfiles/github-0479-often.xetex.tlg
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,9 @@ LaTeX Info: Redefining \ulcshape on input line ....
LaTeX Info: Redefining \swshape on input line ....
LaTeX Info: Redefining \sscshape on input line ....
Already applied: [....-..-..] Font shape change rules on input line ....
Skipping: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Rules for ssc and sw on input line ....
Already applied: [....-..-..] Rules for ssc and sw on input line ....
Skipping: [....-..-..] Font shape change on input line ....
Applying: [....-..-..] Font shape change on input line ....
LaTeX Info: Redefining \fontshape on input line ....
Expand Down
6 changes: 6 additions & 0 deletions base/testfiles/tlb-latexrelease-rollback-003-often.luatex.tlg
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,9 @@ Skipping: [....-..-..] Merge series values on input line ....
Applying: [....-..-..] Merge series values on input line ....
Skipping: [....-..-..] Font shape change rules on input line ....
Applying: [....-..-..] Font shape change rules on input line ....
Skipping: [....-..-..] Rules for ssc and sw on input line ....
Skipping: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Rules for ssc and sw on input line ....
Skipping: [....-..-..] Font shape change on input line ....
Skipping: [....-..-..] Font shape change on input line ....
Applying: [....-..-..] Font shape change on input line ....
Expand Down Expand Up @@ -1252,6 +1255,9 @@ Skipping: [....-..-..] Merge series values on input line ....
Applying: [....-..-..] Merge series values on input line ....
Skipping: [....-..-..] Font shape change rules on input line ....
Applying: [....-..-..] Font shape change rules on input line ....
Skipping: [....-..-..] Rules for ssc and sw on input line ....
Skipping: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Rules for ssc and sw on input line ....
Skipping: [....-..-..] Font shape change on input line ....
Skipping: [....-..-..] Font shape change on input line ....
Applying: [....-..-..] Font shape change on input line ....
Expand Down
6 changes: 6 additions & 0 deletions base/testfiles/tlb-latexrelease-rollback-003-often.tlg
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,9 @@ Skipping: [....-..-..] Merge series values on input line ....
Applying: [....-..-..] Merge series values on input line ....
Skipping: [....-..-..] Font shape change rules on input line ....
Applying: [....-..-..] Font shape change rules on input line ....
Skipping: [....-..-..] Rules for ssc and sw on input line ....
Skipping: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Rules for ssc and sw on input line ....
Skipping: [....-..-..] Font shape change on input line ....
Skipping: [....-..-..] Font shape change on input line ....
Applying: [....-..-..] Font shape change on input line ....
Expand Down Expand Up @@ -1236,6 +1239,9 @@ Skipping: [....-..-..] Merge series values on input line ....
Applying: [....-..-..] Merge series values on input line ....
Skipping: [....-..-..] Font shape change rules on input line ....
Applying: [....-..-..] Font shape change rules on input line ....
Skipping: [....-..-..] Rules for ssc and sw on input line ....
Skipping: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Rules for ssc and sw on input line ....
Skipping: [....-..-..] Font shape change on input line ....
Skipping: [....-..-..] Font shape change on input line ....
Applying: [....-..-..] Font shape change on input line ....
Expand Down
6 changes: 6 additions & 0 deletions base/testfiles/tlb-latexrelease-rollback-003-often.xetex.tlg
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,9 @@ Skipping: [....-..-..] Merge series values on input line ....
Applying: [....-..-..] Merge series values on input line ....
Skipping: [....-..-..] Font shape change rules on input line ....
Applying: [....-..-..] Font shape change rules on input line ....
Skipping: [....-..-..] Rules for ssc and sw on input line ....
Skipping: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Rules for ssc and sw on input line ....
Skipping: [....-..-..] Font shape change on input line ....
Skipping: [....-..-..] Font shape change on input line ....
Applying: [....-..-..] Font shape change on input line ....
Expand Down Expand Up @@ -1245,6 +1248,9 @@ Skipping: [....-..-..] Merge series values on input line ....
Applying: [....-..-..] Merge series values on input line ....
Skipping: [....-..-..] Font shape change rules on input line ....
Applying: [....-..-..] Font shape change rules on input line ....
Skipping: [....-..-..] Rules for ssc and sw on input line ....
Skipping: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Rules for ssc and sw on input line ....
Skipping: [....-..-..] Font shape change on input line ....
Skipping: [....-..-..] Font shape change on input line ....
Applying: [....-..-..] Font shape change on input line ....
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,9 @@ LaTeX Info: Redefining \ulcshape on input line ....
LaTeX Info: Redefining \swshape on input line ....
LaTeX Info: Redefining \sscshape on input line ....
Already applied: [....-..-..] Font shape change rules on input line ....
Skipping: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Rules for ssc and sw on input line ....
Already applied: [....-..-..] Rules for ssc and sw on input line ....
Skipping: [....-..-..] Font shape change on input line ....
Applying: [....-..-..] Font shape change on input line ....
LaTeX Info: Redefining \fontshape on input line ....
Expand Down
3 changes: 3 additions & 0 deletions base/testfiles/tlb-latexrelease-rollback-2020-10-01.tlg
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,9 @@ LaTeX Info: Redefining \ulcshape on input line ....
LaTeX Info: Redefining \swshape on input line ....
LaTeX Info: Redefining \sscshape on input line ....
Already applied: [....-..-..] Font shape change rules on input line ....
Skipping: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Rules for ssc and sw on input line ....
Already applied: [....-..-..] Rules for ssc and sw on input line ....
Skipping: [....-..-..] Font shape change on input line ....
Applying: [....-..-..] Font shape change on input line ....
LaTeX Info: Redefining \fontshape on input line ....
Expand Down
3 changes: 3 additions & 0 deletions base/testfiles/tlb-latexrelease-rollback-2020-10-01.xetex.tlg
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,9 @@ LaTeX Info: Redefining \ulcshape on input line ....
LaTeX Info: Redefining \swshape on input line ....
LaTeX Info: Redefining \sscshape on input line ....
Already applied: [....-..-..] Font shape change rules on input line ....
Skipping: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Rules for ssc and sw on input line ....
Already applied: [....-..-..] Rules for ssc and sw on input line ....
Skipping: [....-..-..] Font shape change on input line ....
Applying: [....-..-..] Font shape change on input line ....
LaTeX Info: Redefining \fontshape on input line ....
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -421,6 +421,9 @@ LaTeX Info: Redefining \ulcshape on input line ....
LaTeX Info: Redefining \swshape on input line ....
LaTeX Info: Redefining \sscshape on input line ....
Already applied: [....-..-..] Font shape change rules on input line ....
Skipping: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Rules for ssc and sw on input line ....
Already applied: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Font shape change on input line ....
LaTeX Info: Redefining \fontshape on input line ....
LaTeX Info: Redefining \fontshapeforce on input line ....
Expand Down
3 changes: 3 additions & 0 deletions base/testfiles/tlb-latexrelease-rollback-2021-06-01.tlg
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,9 @@ LaTeX Info: Redefining \ulcshape on input line ....
LaTeX Info: Redefining \swshape on input line ....
LaTeX Info: Redefining \sscshape on input line ....
Already applied: [....-..-..] Font shape change rules on input line ....
Skipping: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Rules for ssc and sw on input line ....
Already applied: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Font shape change on input line ....
LaTeX Info: Redefining \fontshape on input line ....
LaTeX Info: Redefining \fontshapeforce on input line ....
Expand Down
3 changes: 3 additions & 0 deletions base/testfiles/tlb-latexrelease-rollback-2021-06-01.xetex.tlg
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,9 @@ LaTeX Info: Redefining \ulcshape on input line ....
LaTeX Info: Redefining \swshape on input line ....
LaTeX Info: Redefining \sscshape on input line ....
Already applied: [....-..-..] Font shape change rules on input line ....
Skipping: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Rules for ssc and sw on input line ....
Already applied: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Font shape change on input line ....
LaTeX Info: Redefining \fontshape on input line ....
LaTeX Info: Redefining \fontshapeforce on input line ....
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -421,6 +421,9 @@ LaTeX Info: Redefining \ulcshape on input line ....
LaTeX Info: Redefining \swshape on input line ....
LaTeX Info: Redefining \sscshape on input line ....
Already applied: [....-..-..] Font shape change rules on input line ....
Skipping: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Rules for ssc and sw on input line ....
Already applied: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Font shape change on input line ....
LaTeX Info: Redefining \fontshape on input line ....
LaTeX Info: Redefining \fontshapeforce on input line ....
Expand Down
3 changes: 3 additions & 0 deletions base/testfiles/tlb-latexrelease-rollback-2021-11-15.tlg
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,9 @@ LaTeX Info: Redefining \ulcshape on input line ....
LaTeX Info: Redefining \swshape on input line ....
LaTeX Info: Redefining \sscshape on input line ....
Already applied: [....-..-..] Font shape change rules on input line ....
Skipping: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Rules for ssc and sw on input line ....
Already applied: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Font shape change on input line ....
LaTeX Info: Redefining \fontshape on input line ....
LaTeX Info: Redefining \fontshapeforce on input line ....
Expand Down
3 changes: 3 additions & 0 deletions base/testfiles/tlb-latexrelease-rollback-2021-11-15.xetex.tlg
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,9 @@ LaTeX Info: Redefining \ulcshape on input line ....
LaTeX Info: Redefining \swshape on input line ....
LaTeX Info: Redefining \sscshape on input line ....
Already applied: [....-..-..] Font shape change rules on input line ....
Skipping: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Rules for ssc and sw on input line ....
Already applied: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Font shape change on input line ....
LaTeX Info: Redefining \fontshape on input line ....
LaTeX Info: Redefining \fontshapeforce on input line ....
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,9 @@ LaTeX Info: Redefining \ulcshape on input line ....
LaTeX Info: Redefining \swshape on input line ....
LaTeX Info: Redefining \sscshape on input line ....
Already applied: [....-..-..] Font shape change rules on input line ....
Skipping: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Rules for ssc and sw on input line ....
Already applied: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Font shape change on input line ....
LaTeX Info: Redefining \fontshape on input line ....
LaTeX Info: Redefining \fontshapeforce on input line ....
Expand Down
3 changes: 3 additions & 0 deletions base/testfiles/tlb-latexrelease-rollback-2022-06-01.tlg
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,9 @@ LaTeX Info: Redefining \ulcshape on input line ....
LaTeX Info: Redefining \swshape on input line ....
LaTeX Info: Redefining \sscshape on input line ....
Already applied: [....-..-..] Font shape change rules on input line ....
Skipping: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Rules for ssc and sw on input line ....
Already applied: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Font shape change on input line ....
LaTeX Info: Redefining \fontshape on input line ....
LaTeX Info: Redefining \fontshapeforce on input line ....
Expand Down
3 changes: 3 additions & 0 deletions base/testfiles/tlb-latexrelease-rollback-2022-06-01.xetex.tlg
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,9 @@ LaTeX Info: Redefining \ulcshape on input line ....
LaTeX Info: Redefining \swshape on input line ....
LaTeX Info: Redefining \sscshape on input line ....
Already applied: [....-..-..] Font shape change rules on input line ....
Skipping: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Rules for ssc and sw on input line ....
Already applied: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Font shape change on input line ....
LaTeX Info: Redefining \fontshape on input line ....
LaTeX Info: Redefining \fontshapeforce on input line ....
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,9 @@ LaTeX Info: Redefining \ulcshape on input line ....
LaTeX Info: Redefining \swshape on input line ....
LaTeX Info: Redefining \sscshape on input line ....
Already applied: [....-..-..] Font shape change rules on input line ....
Skipping: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Rules for ssc and sw on input line ....
Already applied: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Font shape change on input line ....
LaTeX Info: Redefining \fontshape on input line ....
LaTeX Info: Redefining \fontshapeforce on input line ....
Expand Down
3 changes: 3 additions & 0 deletions base/testfiles/tlb-latexrelease-rollback-2022-11-01.tlg
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,9 @@ LaTeX Info: Redefining \ulcshape on input line ....
LaTeX Info: Redefining \swshape on input line ....
LaTeX Info: Redefining \sscshape on input line ....
Already applied: [....-..-..] Font shape change rules on input line ....
Skipping: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Rules for ssc and sw on input line ....
Already applied: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Font shape change on input line ....
LaTeX Info: Redefining \fontshape on input line ....
LaTeX Info: Redefining \fontshapeforce on input line ....
Expand Down
3 changes: 3 additions & 0 deletions base/testfiles/tlb-latexrelease-rollback-2022-11-01.xetex.tlg
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,9 @@ LaTeX Info: Redefining \ulcshape on input line ....
LaTeX Info: Redefining \swshape on input line ....
LaTeX Info: Redefining \sscshape on input line ....
Already applied: [....-..-..] Font shape change rules on input line ....
Skipping: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Rules for ssc and sw on input line ....
Already applied: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Font shape change on input line ....
LaTeX Info: Redefining \fontshape on input line ....
LaTeX Info: Redefining \fontshapeforce on input line ....
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,9 @@ LaTeX Info: Redefining \ulcshape on input line ....
LaTeX Info: Redefining \swshape on input line ....
LaTeX Info: Redefining \sscshape on input line ....
Already applied: [....-..-..] Font shape change rules on input line ....
Skipping: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Rules for ssc and sw on input line ....
Already applied: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Font shape change on input line ....
LaTeX Info: Redefining \fontshape on input line ....
LaTeX Info: Redefining \fontshapeforce on input line ....
Expand Down
3 changes: 3 additions & 0 deletions base/testfiles/tlb-latexrelease-rollback-2023-06-01.tlg
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,9 @@ LaTeX Info: Redefining \ulcshape on input line ....
LaTeX Info: Redefining \swshape on input line ....
LaTeX Info: Redefining \sscshape on input line ....
Already applied: [....-..-..] Font shape change rules on input line ....
Skipping: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Rules for ssc and sw on input line ....
Already applied: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Font shape change on input line ....
LaTeX Info: Redefining \fontshape on input line ....
LaTeX Info: Redefining \fontshapeforce on input line ....
Expand Down
3 changes: 3 additions & 0 deletions base/testfiles/tlb-latexrelease-rollback-2023-06-01.xetex.tlg
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,9 @@ LaTeX Info: Redefining \ulcshape on input line ....
LaTeX Info: Redefining \swshape on input line ....
LaTeX Info: Redefining \sscshape on input line ....
Already applied: [....-..-..] Font shape change rules on input line ....
Skipping: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Rules for ssc and sw on input line ....
Already applied: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Font shape change on input line ....
LaTeX Info: Redefining \fontshape on input line ....
LaTeX Info: Redefining \fontshapeforce on input line ....
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,9 @@ LaTeX Info: Redefining \ulcshape on input line ....
LaTeX Info: Redefining \swshape on input line ....
LaTeX Info: Redefining \sscshape on input line ....
Already applied: [....-..-..] Font shape change rules on input line ....
Skipping: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Rules for ssc and sw on input line ....
Already applied: [....-..-..] Rules for ssc and sw on input line ....
Applying: [....-..-..] Font shape change on input line ....
LaTeX Info: Redefining \fontshape on input line ....
LaTeX Info: Redefining \fontshapeforce on input line ....
Expand Down
Loading

0 comments on commit 0e87160

Please sign in to comment.