Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing permissions in Pages workflow #523

Merged
merged 2 commits into from
May 18, 2024
Merged

Fix missing permissions in Pages workflow #523

merged 2 commits into from
May 18, 2024

Commits on May 17, 2024

  1. Revert "back out changes to pages, no time to debug" 

    This reverts commit 56a4d03.
    @muzimuzhi
    muzimuzhi committed May 17, 2024
    Configuration menu
    Copy the full SHA
    e5aae75 View commit details
    Browse the repository at this point in the history

  2. Fix missing permissions 

    actions/jekyll-build-pages is a Docker action hence is run by the default Docker
user (root). So we need sudo in copying into the directory created by Jekyll.
See actions/jekyll-build-pages#101.

https://docs.github.com/en/actions/creating-actions/dockerfile-support-for-github-actions#user
    @muzimuzhi
    muzimuzhi committed May 17, 2024
    Configuration menu
    Copy the full SHA
    cf16dfc View commit details
    Browse the repository at this point in the history