[docs] 1/n Update getting started Code Snippets #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ankush-lastmile
changed the title
Ankush-lastmile
force-pushed
the
pr488
branch
4 times, most recently
from
c48b50b to
efaa34f
Compare
Ankush-lastmile
requested review from
saqadri,
rholinshead,
suyoglastmileai,
jonathanlastmileai and
rossdanlm
as code owners
saqadri
approved these changes
Dec 15, 2023
|
|
||
| # Run a single prompt | ||
| await config.run("get_activities") | ||
| result = await aiconfig.run("get_activities") | ||
| printr(result) |
There was a problem hiding this comment.
Is this needed? Also, should this be print?
There was a problem hiding this comment.
This code executes silently without a print statement. Nothing gets printed to stdout and the user doesn't see anything. It would make sense for the user to see the output
Yes printr is a typo, thanks for catching
| @@ -258,11 +274,10 @@ Let's run this with AIConfig: | |||
| Replace `config.run` above with this: | |||
|
|
|||
| ```python | |||
| inference_options = InferenceOptions(stream=True) | |||
There was a problem hiding this comment.
Don't we still need this? Or is this set earlier already?
There was a problem hiding this comment.
It is set earlier. Now, User just needs to update the aiconfig.run() call, which uses the previous Inference Options
Small changes that make it easier to copy paste and run (and have it work)
Ankush-lastmile
force-pushed
the
pr488
branch
from
efaa34f to
737f6c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[docs] 1/n Update getting started Code Snippets
Small changes that make it easier to copy paste and run (and have it work)