Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2/n [ts] tests #353

Closed
wants to merge 2 commits into from
Closed

2/n [ts] tests #353

wants to merge 2 commits into from

Conversation

Ankush-lastmile
Copy link
Member

@Ankush-lastmile Ankush-lastmile commented Nov 29, 2023 •
edited
Loading

@Ankush-lastmile Ankush-lastmile mentioned this pull request Nov 29, 2023
Closed
@Ankush-lastmile Ankush-lastmile mentioned this pull request Nov 30, 2023
Closed
@Ankush-lastmile Ankush-lastmile force-pushed the pr353 branch 6 times, most recently from 3031c40 to 39ae6aa Compare December 5, 2023 22:28
Ankush Pala [email protected] added 2 commits December 5, 2023 17:31
1/n align deserialize() to library design
b9168ec 
## What

Exclude Previous Run Outputs when performing config.resolve(), aka, model parser `.deserialize()`

## Why

When resolving (deserializing) a prompt, if the prompt as executed before, the output from the previous execution is currently included in the deserialized state. While this was the expected behbaiour in the past, it has become apparent that including previous outputs is counterintuitive and not user-friendly
2/n [ts] tests
b09315d
@Ankush-lastmile Ankush-lastmile changed the title [ts] tests 2/n [ts] tests Dec 5, 2023
@Ankush-lastmile Ankush-lastmile marked this pull request as ready for review December 6, 2023 16:15
jonathanlastmileai
jonathanlastmileai reviewed Dec 6, 2023
View reviewed changes
Copy link
Contributor

@jonathanlastmileai jonathanlastmileai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it's blocked by 1/n align deserialize() to library design.

@Ankush-lastmile
Copy link
Member Author

Ankush-lastmile commented Dec 14, 2023 •
edited
Loading

closed in favor of #491

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanlastmileai jonathanlastmileai jonathanlastmileai left review comments

@saqadri saqadri Awaiting requested review from saqadri saqadri is a code owner

@rholinshead rholinshead Awaiting requested review from rholinshead rholinshead is a code owner

@suyoglastmileai suyoglastmileai Awaiting requested review from suyoglastmileai

@rossdanlm rossdanlm Awaiting requested review from rossdanlm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ankush-lastmile @jonathanlastmileai