[AIC-PY] + publish script for any pypi pkg, small mods to llama ext #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jonathanlastmileai
requested review from
rholinshead,
saqadri,
Ankush-lastmile and
rossdanlm
jonathanlastmileai
force-pushed
the
pr265
branch
from
f916343 to
70d8fe2
Compare
| @@ -0,0 +1,37 @@ | |||
| #! /bin/zsh | |||
| # pypipublish.sh | |||
| # Usage: Run ./scripts/pypipublish.sh path/to/project/root conda-env-name | |||
There was a problem hiding this comment.
Wouldn't it make more sense to create an empty environment rather than depend on an existing one?
| # Need to get a token from here (scroll down to API Tokens): https://pypi.org/manage/account/ | ||
| # If you have issues, read the docs: https://packaging.python.org/en/latest/tutorials/packaging-projects/ | ||
|
|
||
| # If you want to upload to testpypi, run pypipublish-test.sh. |
There was a problem hiding this comment.
does this exist? I don't see it in this diff
| # For the password, use the token value, including the pypi- prefix. | ||
| # To get a PyPi token, go here: | ||
| # Need to get a token from here (scroll down to API Tokens): https://pypi.org/manage/account/ | ||
| # If you have issues, read the docs: https://packaging.python.org/en/latest/tutorials/packaging-projects/ |
There was a problem hiding this comment.
Is publishing with account username and password an expected flow? I've noticed that the official publishing guide suggests using token
I think it would make more sense to expect .env or equivalent rather than typing it in at script run?
Ankush-lastmile
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[AIC-PY] + publish script for any pypi pkg, small mods to llama ext
Stack created with Sapling. Best reviewed with ReviewStack.