Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py] Bump to 1.0.9 #195

Merged
merged 1 commit into from
Nov 16, 2023
Merged

[py] Bump to 1.0.9 #195

merged 1 commit into from
Nov 16, 2023

Conversation

Ankush-lastmile
Copy link
Member

@Ankush-lastmile Ankush-lastmile commented Nov 14, 2023

[py] Bump to 1.0.9

Republished AIConfig to 1.0.8 Changes Made Locally:
updated dependencies in pyproject.toml, should be good to go on that front.
(small) added an await statement that was missing for a callback
changes made locally
If any problems arise please let me know, I will fix asap.

1.0.9:

  • Updated openai version to >1.0.0
  • updated model parser and wrapper as well

@Ankush-lastmile Ankush-lastmile marked this pull request as ready for review November 14, 2023 15:14
Comment on lines +29 to +30
"result",
"nest_asyncio",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed now? cc @jonathanlastmileai to validate. Otherwise lgtm

Copy link
Member Author

@Ankush-lastmile Ankush-lastmile Nov 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

result is the library dependency we used for the OK and error types.

nest_asyncio is used in the OpenAI introspection wrapper to allow execution in Jupyter Notebook/ipynb env.

ipynb cells are all in an async event loop by default. This makes it challenging to do a synchronous -> asynchronous call inside of a ipynb cell, nest_asyncio allows us to do that

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I dont think you need nest_asyncio with recent jupyter versions

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also @LastMileNewGrad why don't we add a changelog?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where would the changelog go? I presume discussions would the best

Republished AIConfig to 1.0.8 Changes Made Locally:
updated dependencies in pyproject.toml, should be good to go on that front.
(small) added an await statement that was missing for a callback
changes made locally
If any problems arise please let me know, I will fix asap.

1.0.9:

- Updated openai version to >1.0.0
- updated model parser and wrapper as well
@Ankush-lastmile
Copy link
Member Author

rebase

@Ankush-lastmile Ankush-lastmile merged commit f26364d into main Nov 16, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants