-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py] Bump to 1.0.9 #195
[py] Bump to 1.0.9 #195
Conversation
5f31405
to
89708e5
Compare
"result", | ||
"nest_asyncio", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed now? cc @jonathanlastmileai to validate. Otherwise lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
result
is the library dependency we used for the OK
and error
types.
nest_asyncio
is used in the OpenAI introspection wrapper to allow execution in Jupyter Notebook/ipynb env.
ipynb cells are all in an async event loop by default. This makes it challenging to do a synchronous -> asynchronous call inside of a ipynb cell, nest_asyncio allows us to do that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW I dont think you need nest_asyncio with recent jupyter versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also @LastMileNewGrad why don't we add a changelog?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where would the changelog go? I presume discussions would the best
Republished AIConfig to 1.0.8 Changes Made Locally: updated dependencies in pyproject.toml, should be good to go on that front. (small) added an await statement that was missing for a callback changes made locally If any problems arise please let me know, I will fix asap. 1.0.9: - Updated openai version to >1.0.0 - updated model parser and wrapper as well
89708e5
to
68f03ee
Compare
rebase |
[py] Bump to 1.0.9
Republished AIConfig to 1.0.8 Changes Made Locally:
updated dependencies in pyproject.toml, should be good to go on that front.
(small) added an await statement that was missing for a callback
changes made locally
If any problems arise please let me know, I will fix asap.
1.0.9: