[Python] Openai Wrapper improvements #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ankush-lastmile
force-pushed
the
pr176
branch
from
6806c16 to
049a822
Compare
saqadri
approved these changes
Nov 10, 2023
## What 1. Save outputs 2. Allow passing a file path 3. Allow passing an AIConfig object 4. Persist output with streaming enabled (pass through streaming) Notes: - With streaming, we can either capture the response and not return it to the user or use pass through streaming, but, if the stream completion is not fully iterated through, ie the user doesn't touch the completion, completion args doesn't get serialized. Can't do both due to the nature of what it entails - - chose to go with pass through streaming - If the completion has a prompt that is already in the config (same input, settings, etc) but different outputs, the outputs are overriden with the new one - if one completion is streamed, and another is not, those are considered different prompts and get serialized as such - Added a dependency on nest_asyncio to make this work in ipynb. ## Why Wrapper needs to be customizable and flexible
Ankush-lastmile
force-pushed
the
pr176
branch
from
049a822 to
1fe9d7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Python] Openai Wrapper improvements
What
Notes:
With streaming, we can either capture the response and not return it to the user or use pass through streaming, but, if the stream completion is not fully iterated through, ie the user doesn't touch the completion, completion args doesn't get serialized. Can't do both due to the nature of what it entails
If the completion has a prompt that is already in the config (same input, settings, etc) but different outputs, the outputs are overriden with the new one
if one completion is streamed, and another is not, those are considered different prompts and get serialized as such
Added a dependency on nest_asyncio to make this work in ipynb.
Why
Wrapper needs to be customizable and flexible
Stack created with Sapling. Best reviewed with ReviewStack.