File navigaiton for aiconfig editor #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 10, 2023
suyoglastmileai
changed the title
suyoglastmileai
force-pushed
the
pr168
branch
from
755d28f to
75f51df
Compare
|
Navigate from root directory (this is not currently configurable via CLI, but is good enough for testing) AiconfigNavigation.mov |
rholinshead
approved these changes
Nov 22, 2023
| console.log(res); | ||
| }, [path]); | ||
| const newFiles = res.files.map((file: EditorFile) => { | ||
| const disabled = !file.isDirectory && file.extension !== ".json"; |
There was a problem hiding this comment.
Should probably just filter these out from the response itself?
There was a problem hiding this comment.
I think it's useful to view the files otherwise people will get confused that the directories aren't showing everything
| (file: EditorFile) => { | ||
| // If directory, then change path & also update the url route to add to history | ||
| // If random file, should not be able to select | ||
| // If aiconfig.json file, then open editor - can't actually detect yet, so will just try to parse |
There was a problem hiding this comment.
Ah, this is another place the load schema validation would help; #291
suyoglastmileai
force-pushed
the
pr168
branch
from
75f51df to
12ef084
Compare
suyoglastmileai
requested review from
Ankush-lastmile,
jonathanlastmileai and
rossdanlm
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File navigaiton for aiconfig editor
Stack created with Sapling. Best reviewed with ReviewStack.