[editor] Fix Model Parsers prompt_metadata remember_chat_context #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 9, 2024
rholinshead
requested review from
saqadri,
suyoglastmileai,
Ankush-lastmile,
jonathanlastmileai and
rossdanlm
as code owners
rossdanlm
reviewed
Feb 9, 2024
| }, | ||
| }, | ||
| required: ["model", "max_tokens_to_sample", "stop_sequences"], |
There was a problem hiding this comment.
This is just UI for now right? Doesn't actually enforce the required-ness?
There was a problem hiding this comment.
Ya, just shows the red required * for the setting input. Also, just noting this was existing code
| @@ -14,7 +14,7 @@ export const ClaudeBedrockPromptSchema: PromptSchema = { | |||
| type: "string", | |||
| }, | |||
| max_tokens_to_sample: { | |||
| type: "number", | |||
| type: "integer", | |||
There was a problem hiding this comment.
nice catch! did you look at the docs for this or did an error pop up when testing locally?
There was a problem hiding this comment.
Just noticed it when testing locally that it allowed setting floats which didn't make sense in my mind, so checked to confirm before updating
added 3 commits
February 15, 2024 11:35
# [editor] Add 'Metadata' Tab to Prompt Side Pane Currently the editor does not provide a way to modify general prompt metadata, outside of model settings and parameters. For some of our chat parsers, this means the user cannot modify the 'remember_chat_context' setting. This PR implements the UX for modifying this metadata, adding it as a tab in the side panel and associated with prompt_metadata in the prompt schema: https://github.com/lastmile-ai/aiconfig/assets/5060851/353e2e47-2210-4351-96ef-81eea03c2aab   Make sure generic metadata can be set as well: <img width="437" alt="Screenshot 2024-02-09 at 11 22 55 AM" src="https://github.com/lastmile-ai/aiconfig/assets/5060851/6e4fbe08-280c-4fa2-9610-4ee86e1cfc2d">
# [editor][ez] Only Render SidePanel Tab Content When Active Tab I noticed each of the tab components was being rendered even when they're not shown. We can improve render perf by only rendering them when their tab is selected. ## Testing: - Just ensure tabs still work - Use console.log to ensure the components are only rendered when shown
# [editor] Fix Model Parsers prompt_metadata remember_chat_context Update the relevant model parsers to have default and description for remember_chat_context. Also, remove it from the ones that don't actually support it in their parser
saqadri
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[editor] Fix Model Parsers prompt_metadata remember_chat_context
[editor] Fix Model Parsers prompt_metadata remember_chat_context
Update the relevant model parsers to have default and description for remember_chat_context. Also, remove it from the ones that don't actually support it in their parser
Stack created with Sapling. Best reviewed with ReviewStack.