-
Notifications
You must be signed in to change notification settings - Fork 81
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add completion events to walkthrough steps (#1340)
Add completion events to walkthrough steps Ok, upon further investigation, I found out that the `completionEvents` doesn't actually do anything anymore: microsoft/vscode#176074 (comment). However, this no-op is being reverted in next VS Code update in microsoft/vscode#176074 (comment), so it's still good to included this here!!! We should then advertise to people to pls update their VS Code version!!! You can read more about completion events in https://code.visualstudio.com/api/references/contribution-points#Completion-events ~~Now we shouldn't auto-mark steps as completed unless command has been run~~ I also added "CMD/CTRL" to the readme files and renamed the readme files to be non-capitalized. I also made some content changes in the walkthrough mardown because it was annoying me, but feel it's better and more precise. ## Test Plan This actually has no functional changes at all becuase of microsoft/vscode#176074 (comment) until users update the latest VS Code version (which I tried to do but still doesn't work for me :/ ) https://github.com/lastmile-ai/aiconfig/assets/151060367/d9a74035-1951-4cf7-adbc-4c4b2bcad6c1 Trying on Jupyter notebooks walkthrough also doesn't work for me https://github.com/lastmile-ai/aiconfig/assets/151060367/39231e92-fe53-41bd-ac4a-cf94725975f5 ## Appendix The timeline for this is pretty wild: 1. Someone doesn't like having checkboxes so removed the functionality in microsoft/vscode#166747 to automatically check once a step is viewed. The PR for addressing this was done in Jan 31, 2023: microsoft/vscode#172941 2. People complained about this, so microsoft/vscode#176074 was filed on March 3, 2023 3. Change for reverting back to original completionEvent feature was done in January 24, 2024: microsoft/vscode#203573 --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/lastmile-ai/aiconfig/pull/1340). * #1346 * #1345 * #1343 * #1341 * __->__ #1340 * #1329
- Loading branch information
Showing
5 changed files
with
20 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters