let dicomweb-client handle pagination

[vanossj]

Newer versions of dicomweb-client have a get_remaining param that will handle the offset/limit pagination and return all the studies/series/instances queried

[lassoan]

DCM.js DICOM server (and maybe others) don't do pagination: they simple ignore the offset parameter and always return all results. That's why the duplicate study instance UID check was added into this extension's pagination implementation.

Does DICOMweb-client's pagination implentation include such duplicate instance UID check?

[vanossj]

blocked by this issue in dcmjs server

[lassoan]

One solution to get this merged would be to convince dicomweb-client developers to allow more robust pagination. Essentially, suggest them to implement the same #19 to be able to communicate with all servers that do not support pagination.

The API could be something like

self.DICOMwebClient.search_for_studies(get_remaining_auto=True)

or

self.DICOMwebClient.search_for_studies(get_remaining=True, prevent_duplicates=True)

Or the option could be always enabled, but a warning would be displayed when the loop is ended due to duplicate item. We would need a way to suppress this warning though, as we would not want to pollute the logs with this (although the behavior does not conform to the standard, it is a harmless error).

If dicomweb-client developers don't wan to do this (whichi would be understandable, because it would mean that their client would be more complex because of server non-conformances) then the dcmjs server must be fixed before this can be merged.

[vanossj]

I think the right answer is to fix DCMjs

[lassoan]

In that case, I think we should change this PR to just add a comment in the code in _get_all_pages describing what change to make when dcmjs-org/dicomweb-server#19 is fixed.