Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mio requirement from 0.6.17 to 0.8.9 #4

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Nov 17, 2023

Updates the requirements on mio to permit the latest version.

Changelog

Sourced from mio's changelog.

0.8.9

Added

Fixed

0.8.8

Fixed

0.8.7

Added

  • Add/fix support for tvOS and watchOS, Mio should now build for tvOS and watchOS, but we don't have a CI setup yet (tokio-rs/mio#1658).

Changed

  • Made the log dependency optional behind the log feature flag (enabled by default). Users that disabled Mio's default features will now not see any logging from Mio, enabling the log feature will fix that. This was done in response to the log crate increasing it's MSRV to v1.60, see rust-lang/log#552 (tokio-rs/mio#1673).
  • Update windows-sys dependency to v0.48 (tokio-rs/mio#1663).

... (truncated)

Commits
  • e80c3b2 Release v0.8.9
  • 862786b Fix importing of IoSourceState
  • 4034872 Add support for vita target
  • 8eb4010 Fix receiver and sender fd in pipe based waker
  • 9f21ce1 Enable sys::unix::pipe when using pipe based Waker
  • e7a0685 Reuse pipe2 polyfill code
  • 808dbb0 Implement pipe2 for AIX
  • 605ba78 Add AIX operating system support
  • 8dd37c5 Skip MSRV test for macOS
  • 2856112 Run the MSRV CI check on more platforms
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [mio](https://github.com/tokio-rs/mio) to permit the latest version.
- [Release notes](https://github.com/tokio-rs/mio/releases)
- [Changelog](https://github.com/tokio-rs/mio/blob/master/CHANGELOG.md)
- [Commits](tokio-rs/mio@v0.6.17...v0.8.9)

---
updated-dependencies:
- dependency-name: mio
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Nov 17, 2023
Copy link
Author

dependabot bot commented on behalf of github Dec 11, 2023

Superseded by #8.

@dependabot dependabot bot closed this Dec 11, 2023
@dependabot dependabot bot deleted the dependabot/cargo/mio-0.8.9 branch December 11, 2023 15:57
larseggert added a commit that referenced this pull request Jun 19, 2024
They seem to have a race condition that makes them crash.

I wasn't able to figure out why they crash, this seems to happen
inside NSS:
```
Process 47677 stopped
* thread #2, name = 'init_twice_withdb', stop reason = EXC_BAD_ACCESS (code=1, address=0x0)
    frame #0: 0x000000019b4994f8 libsystem_pthread.dylib`pthread_mutex_lock + 12
libsystem_pthread.dylib`pthread_mutex_lock:
->  0x19b4994f8 <+12>: ldr    x8, [x0]
    0x19b4994fc <+16>: mov    w9, #0x545a ; =21594
    0x19b499500 <+20>: movk   w9, #0x4d55, lsl #16
    0x19b499504 <+24>: cmp    x8, x9
(lldb) up
frame #1: 0x0000000100802f58 libnspr4.dylib`PR_Lock + 20
libnspr4.dylib`PR_Lock:
->  0x100802f58 <+20>: bl     0x10080c0c0    ; symbol stub for: pthread_self
    0x100802f5c <+24>: str    x0, [x19, #0xb8]
    0x100802f60 <+28>: mov    w8, #0x1 ; =1
    0x100802f64 <+32>: str    w8, [x19, #0xb0]
(lldb) up
frame #2: 0x00000001007fc188 libnspr4.dylib`PR_CallOnce + 56
libnspr4.dylib`PR_CallOnce:
->  0x1007fc188 <+56>: ldr    w23, [x19]
    0x1007fc18c <+60>: ldr    w20, [x19, #0x8]
    0x1007fc190 <+64>: ldr    x0, [x22, #0x430]
    0x1007fc194 <+68>: bl     0x100802f74    ; PR_Unlock
(lldb) up
frame #3: 0x000000010066f634 libnss3.dylib`nss_Init + 112
libnss3.dylib`nss_Init:
->  0x10066f634 <+112>: cbz    w0, 0x10066f640 ; <+124>
    0x10066f638 <+116>: mov    w19, #-0x1 ; =-1
    0x10066f63c <+120>: b      0x10066f968    ; <+932>
    0x10066f640 <+124>: stp    x21, x22, [x29, #-0x80]
(lldb) up
frame #4: 0x000000010066ff44 libnss3.dylib`NSS_Initialize + 100
libnss3.dylib`NSS_Initialize:
->  0x10066ff44 <+100>: ldp    x29, x30, [sp, #0x40]
    0x10066ff48 <+104>: add    sp, sp, #0x50
    0x10066ff4c <+108>: ret

libnss3.dylib`NSS_InitContext:
    0x10066ff50 <+0>:   sub    sp, sp, #0x60
(lldb) up
frame #5: 0x00000001000035fc init-d4e9f02b33e50e46`init::init_twice_withdb::h34013f715e9b4f6e at init.rs:65:9
   62  	    let pathstr = path.to_str().unwrap();
   63  	    let dircstr = CString::new(pathstr).unwrap();
   64  	    unsafe {
-> 65  	        nss::NSS_Initialize(
   66  	            dircstr.as_ptr(),
   67  	            empty.as_ptr(),
   68  	            empty.as_ptr(),
```
larseggert added a commit that referenced this pull request Jul 1, 2024
They seem to have a race condition that makes them crash.

I wasn't able to figure out why they crash, this seems to happen
inside NSS:
```
Process 47677 stopped
* thread #2, name = 'init_twice_withdb', stop reason = EXC_BAD_ACCESS (code=1, address=0x0)
    frame #0: 0x000000019b4994f8 libsystem_pthread.dylib`pthread_mutex_lock + 12
libsystem_pthread.dylib`pthread_mutex_lock:
->  0x19b4994f8 <+12>: ldr    x8, [x0]
    0x19b4994fc <+16>: mov    w9, #0x545a ; =21594
    0x19b499500 <+20>: movk   w9, #0x4d55, lsl #16
    0x19b499504 <+24>: cmp    x8, x9
(lldb) up
frame #1: 0x0000000100802f58 libnspr4.dylib`PR_Lock + 20
libnspr4.dylib`PR_Lock:
->  0x100802f58 <+20>: bl     0x10080c0c0    ; symbol stub for: pthread_self
    0x100802f5c <+24>: str    x0, [x19, #0xb8]
    0x100802f60 <+28>: mov    w8, #0x1 ; =1
    0x100802f64 <+32>: str    w8, [x19, #0xb0]
(lldb) up
frame #2: 0x00000001007fc188 libnspr4.dylib`PR_CallOnce + 56
libnspr4.dylib`PR_CallOnce:
->  0x1007fc188 <+56>: ldr    w23, [x19]
    0x1007fc18c <+60>: ldr    w20, [x19, #0x8]
    0x1007fc190 <+64>: ldr    x0, [x22, #0x430]
    0x1007fc194 <+68>: bl     0x100802f74    ; PR_Unlock
(lldb) up
frame #3: 0x000000010066f634 libnss3.dylib`nss_Init + 112
libnss3.dylib`nss_Init:
->  0x10066f634 <+112>: cbz    w0, 0x10066f640 ; <+124>
    0x10066f638 <+116>: mov    w19, #-0x1 ; =-1
    0x10066f63c <+120>: b      0x10066f968    ; <+932>
    0x10066f640 <+124>: stp    x21, x22, [x29, #-0x80]
(lldb) up
frame #4: 0x000000010066ff44 libnss3.dylib`NSS_Initialize + 100
libnss3.dylib`NSS_Initialize:
->  0x10066ff44 <+100>: ldp    x29, x30, [sp, #0x40]
    0x10066ff48 <+104>: add    sp, sp, #0x50
    0x10066ff4c <+108>: ret

libnss3.dylib`NSS_InitContext:
    0x10066ff50 <+0>:   sub    sp, sp, #0x60
(lldb) up
frame #5: 0x00000001000035fc init-d4e9f02b33e50e46`init::init_twice_withdb::h34013f715e9b4f6e at init.rs:65:9
   62  	    let pathstr = path.to_str().unwrap();
   63  	    let dircstr = CString::new(pathstr).unwrap();
   64  	    unsafe {
-> 65  	        nss::NSS_Initialize(
   66  	            dircstr.as_ptr(),
   67  	            empty.as_ptr(),
   68  	            empty.as_ptr(),
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants