chore: Address new nightly clippy warnings (#2151) #1

	name: Clippy
	on:
	push:
	branches: ["main"]
	paths-ignore: [".md", ".png", ".svg", "LICENSE-"]
	pull_request:
	branches: ["main"]
	paths-ignore: [".md", ".png", ".svg", "LICENSE-"]
	merge_group:
	workflow_dispatch:
	env:
	CARGO_TERM_COLOR: always
	RUST_BACKTRACE: 1

	concurrency:
	group: ${{ github.workflow }}-${{ github.ref_name }}
	cancel-in-progress: true

	permissions:
	contents: read

	jobs:
	clippy:
	strategy:
	fail-fast: false
	matrix:
	os: [ubuntu-latest, macos-latest, windows-latest]
	runs-on: ${{ matrix.os }}
	defaults:
	run:
	shell: bash

	steps:
	- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
	- uses: ./.github/actions/rust
	with:
	components: clippy
	tools: cargo-hack
	token: ${{ secrets.GITHUB_TOKEN }}

	- id: nss-version
	run: echo "minimum=$(cat neqo-crypto/min_version.txt)" >> "$GITHUB_OUTPUT"

	- uses: ./.github/actions/nss
	with:
	minimum-version: ${{ steps.nss-version.outputs.minimum }}

	# Use cargo-hack to run clippy on each crate individually with its
	# respective default features only. Can reveal warnings otherwise
	# hidden given that a plain cargo clippy combines all features of the
	# workspace. See e.g. https://github.com/mozilla/neqo/pull/1695.
	- run: cargo hack clippy --all-targets --feature-powerset --exclude-features gecko -- -D warnings
	- run: cargo doc --workspace --no-deps --document-private-items
	env:
	RUSTDOCFLAGS: "--deny rustdoc::broken_intra_doc_links --deny warnings"

Provide feedback