This repository has been archived by the owner on Jul 16, 2023. It is now read-only.
Match unique rules with no parameters #298
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it stands, the example provided in the README (`'email' => 'required|email|unique',`) doesn't work because `buildUniqueExclusionRules` is searching specifically for `unique:`, ending with a colon.
Presumably this isn't intentional, based on the later `count(explode(':', $params[0]))` check which currently would be impossible to trigger, so the string match has been adjusted.
pjona
approved these changes
Feb 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it stands, the example provided in the README (
'email' => 'required|email|unique',) doesn't work becausebuildUniqueExclusionRulesis searching specifically forunique:, ending with a colon.Presumably this isn't intentional, based on the later
count(explode(':', $params[0]))check which currently would be impossible to trigger, so the string match has been adjusted.That said, is there any concern of matching custom rules starting with 'unique'? The string check could be made more complicated to avoid this, but I personally think of it as a low priority concern.