-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Darkmode and copy of hex dump to clipboard #57
Conversation
Minimalized change to add a darkmode and the feature to copy the selected dump by clicking on the hex view
I didn't know about CSS |
I really love your tool and use it on a daily base. If there is any support I can give you, just tell me. |
BTW: I'm importing your single commits in a new branch (I use monotone internally, git is only a mirror, so I can't keep your commits as is), if you don't mind I prefer to keep history as close as possible to development. So far I'm only importing the "feature/dark", i'll think about the other later. Thanks for the contribution, is really nice! |
Dark mode committed (as is) in 5a007ae. Thanks again! |
You're very welcome! Just give me a hint if you need any support. |
Thanks for the offer. I have two "big" features for the future… which I am not finding enough time for as of late, unfortunately:
Both go pretty deep into |
We should close the pull request and have the discussion in the according issues. |
PS: I'm still interested in the "hex dump" sub-part of this PR, just didn't want to commit together with dark mode. |
Sure, happy to get that one, too. |
I'll get it from your feature branch, thanks. :) |
Was the dump functionality missed in action? |
This is a pull request to add dark mode and the functionality to copy a part of the hex view to the clipboard.
I tried to keep the changes as small as possible.
However, I had to restructure the HTML page in divs to get a "nice" UI.