Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Darkmode and copy of hex dump to clipboard #57

Closed
wants to merge 3 commits into from

Conversation

olibu
Copy link
Contributor

@olibu olibu commented Nov 15, 2022

This is a pull request to add dark mode and the functionality to copy a part of the hex view to the clipboard.

I tried to keep the changes as small as possible.
However, I had to restructure the HTML page in divs to get a "nice" UI.

Minimalized change to add a darkmode and the feature to copy the selected
dump by clicking on the hex view
@lapo-luchini
Copy link
Owner

I didn't know about CSS prefers-color-scheme, nice!

@olibu
Copy link
Contributor Author

olibu commented Nov 17, 2022

I really love your tool and use it on a daily base. If there is any support I can give you, just tell me.
I sometimes need a part of the asn1 structure in hex, so I added this feature, too.
If you want me to remove it I would create a dedicated pull request for the dark mode.

@lapo-luchini
Copy link
Owner

BTW: I'm importing your single commits in a new branch (I use monotone internally, git is only a mirror, so I can't keep your commits as is), if you don't mind I prefer to keep history as close as possible to development.

So far I'm only importing the "feature/dark", i'll think about the other later. Thanks for the contribution, is really nice!

@lapo-luchini
Copy link
Owner

Dark mode committed (as is) in 5a007ae. Thanks again!

@olibu
Copy link
Contributor Author

olibu commented Feb 23, 2023

You're very welcome! Just give me a hint if you need any support.

@lapo-luchini
Copy link
Owner

Thanks for the offer. I have two "big" features for the future… which I am not finding enough time for as of late, unfortunately:

  1. enriching the tree output with parameter names; this is already kinda working from the command line, i.e. most of the work is done, what's lacking is tying it into the DOM output; I was thinking something like a drop-down with some "most used" ASN.1 types from the 3 RFCs I managed to parse so far (X.509, PKCS#7, CRL… a few more maybe) with manual selection… or if it's fast enough, maybe even auto-detection (CLI example already prints a % of recognized nodes using that format, which gies a pretty solid probability it is the right format)
  2. a side-by-side diff mode would be really cool e.g. to compare two different certificates from the same CA and notice immediately that the different nodes are only the serial number and subject CN

Example of 1:
image

Both go pretty deep into asn1.js internals though, and I have doubts about the readability of my code there.

@olibu
Copy link
Contributor Author

olibu commented Feb 23, 2023

We should close the pull request and have the discussion in the according issues.
I found issue #61 for the diff topic.
If you create an issue for the dump feature we can have the discussion there.

@olibu olibu closed this Feb 23, 2023
@lapo-luchini
Copy link
Owner

PS: I'm still interested in the "hex dump" sub-part of this PR, just didn't want to commit together with dark mode.

@olibu
Copy link
Contributor Author

olibu commented Feb 24, 2023

Sure, happy to get that one, too.
Shall I create a dedicated PR or do add it by your own?

@lapo-luchini
Copy link
Owner

I'll get it from your feature branch, thanks. :)

@ceztko
Copy link

ceztko commented Jul 24, 2023

Was the dump functionality missed in action?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants