update infodisplay when WiFi and MQTT become available #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of adding a delay (and making the UI appear slow) could we monitor the WIFI/MQTT state and reload the info display once they are connected? |
|
I refrained from this path, as it would mean waiting for two values and displaying inaccurate content first. What would be your approach? Wait for both after drawing the infodisplay and then partial update? Or full redraw? |
|
I think a partial redraw when the data is ready works, or a full refresh when the data is ready. |
…i status" This reverts commit bb70364.
|
Partial redraw was the way to go, a full refresh just looked too ugly to me in UX terms. |
elratt0r
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the info display, it mostly shows an error for MQTT and WiFi due to the task running earlier/faster than the others. Around 500ms of delay seem to be sufficient to have the correct values there.