Skip to content

Commit

Permalink
Removes tests targeting deprecated and removed methods
Browse files Browse the repository at this point in the history
Signed-off-by: George Steel <[email protected]>
  • Loading branch information
gsteel committed Feb 1, 2022
1 parent 6f52577 commit 3eebe5f
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 40 deletions.
10 changes: 0 additions & 10 deletions psalm-baseline.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1447,9 +1447,6 @@
</RedundantConditionGivenDocblockType>
</file>
<file src="src/Helper/Placeholder/Registry.php">
<DocblockTypeContradiction occurrences="1">
<code>null === static::$instance</code>
</DocblockTypeContradiction>
<InvalidStringClass occurrences="1">
<code>new $this-&gt;containerClass($value)</code>
</InvalidStringClass>
Expand All @@ -1472,9 +1469,6 @@
<code>(string) $key</code>
<code>(string) $key</code>
</RedundantCastGivenDocblockType>
<UnsafeInstantiation occurrences="1">
<code>new static()</code>
</UnsafeInstantiation>
</file>
<file src="src/Helper/RenderChildModel.php">
<MissingConstructor occurrences="2">
Expand Down Expand Up @@ -2361,10 +2355,6 @@
</UndefinedMethod>
</file>
<file src="test/Helper/GravatarTest.php">
<DeprecatedMethod occurrences="2">
<code>getAttribs</code>
<code>setAttribs</code>
</DeprecatedMethod>
<InvalidScalarArgument occurrences="3">
<code>$value</code>
<code>$value</code>
Expand Down
30 changes: 0 additions & 30 deletions test/Helper/GravatarTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -274,34 +274,4 @@ public function testEmailIsProperlyNormalized(): void
$this->helper->__invoke('[email protected] ')->getEmail()
);
}

public function testSetAttribsIsDeprecated(): void
{
$this->expectDeprecation();

$this->helper->setAttribs([]);
}

public function testSetAttribsDocCommentHasDeprecated(): void
{
$method = new ReflectionMethod($this->helper, 'setAttribs');
$comment = $method->getDocComment();

$this->assertStringContainsString('@deprecated', $comment);
}

public function testGetAttribsIsDeprecated(): void
{
$this->expectDeprecation();

$this->helper->getAttribs();
}

public function testGetAttribsDocCommentHasDeprecated(): void
{
$method = new ReflectionMethod($this->helper, 'getAttribs');
$comment = $method->getDocComment();

$this->assertStringContainsString('@deprecated', $comment);
}
}

0 comments on commit 3eebe5f

Please sign in to comment.