Add PHP 8.4 support, drop PHP < 8.2 support

laminas · Aug 8, 2024 · 155b536 · 155b536
1 parent 6312d72
commit 155b536
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 15 deletions.
diff --git a/composer.json b/composer.json
@@ -21,7 +21,7 @@
             "dealerdirect/phpcodesniffer-composer-installer": true
         },
         "platform": {
-            "php": "8.1.99"
+            "php": "8.2.99"
         }
     },
     "extra": {
@@ -31,7 +31,7 @@
         }
     },
     "require": {
-        "php": "~8.1.0 || ~8.2.0 || ~8.3.0",
+        "php": "~8.2.0 || ~8.3.0 || ~8.4.0",
         "laminas/laminas-stdlib": "^3.3",
         "webmozart/assert": "^1.10"
     },

diff --git a/src/Filter/NumberOfParameterFilter.php b/src/Filter/NumberOfParameterFilter.php
@@ -8,6 +8,7 @@
 use ReflectionException;
 use ReflectionMethod;
 
+use function method_exists;
 use function sprintf;
 
 final class NumberOfParameterFilter implements FilterInterface
@@ -31,7 +32,10 @@ public function filter(string $property, ?object $instance = null): bool
         try {
             $reflectionMethod = $instance !== null
                 ? new ReflectionMethod($instance, $property)
-                : new ReflectionMethod($property);
+                : (method_exists(ReflectionMethod::class, 'createFromMethodName')
+                    ? ReflectionMethod::createFromMethodName($property)
+                    : new ReflectionMethod($property)
+                );
         } catch (ReflectionException) {
             throw new InvalidArgumentException(sprintf(
                 'Method %s does not exist',

diff --git a/src/Filter/OptionalParametersFilter.php b/src/Filter/OptionalParametersFilter.php
@@ -11,6 +11,7 @@
 
 use function array_filter;
 use function array_key_exists;
+use function method_exists;
 use function sprintf;
 
 /**
@@ -46,7 +47,10 @@ public function filter(string $property, ?object $instance = null): bool
         try {
             $reflectionMethod = $instance !== null
                 ? new ReflectionMethod($instance, $property)
-                : new ReflectionMethod($property);
+                : (method_exists(ReflectionMethod::class, 'createFromMethodName')
+                    ? ReflectionMethod::createFromMethodName($property)
+                    : new ReflectionMethod($property)
+                );
         } catch (ReflectionException) {
             throw new InvalidArgumentException(sprintf('Method %s does not exist', $property));
         }

diff --git a/test/Strategy/BackedEnumStrategyTest.php b/test/Strategy/BackedEnumStrategyTest.php
@@ -11,20 +11,9 @@
 use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\TestCase;
 
-use const PHP_VERSION_ID;
-
 #[CoversClass(BackedEnumStrategy::class)]
 class BackedEnumStrategyTest extends TestCase
 {
-    protected function setUp(): void
-    {
-        parent::setUp();
-
-        if (PHP_VERSION_ID < 80100) {
-            self::markTestSkipped("PHP 8.1+ required");
-        }
-    }
-
     public function testExtractInvalidValueThrowsException(): void
     {
         $strategy = new BackedEnumStrategy(TestBackedEnum::class);