Performance improvements to get_monthly_user_activity() #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a 33K users Moodle install. and for us to be able to run this (beautiful) report on a per course basis, without timeout errors, we needed to narrow the graphs population to the users of that specific course. (It's seems also the right thing to do, regardless performance) So I am adding the suggested patch to include only the users of the specific course being viewed. Please review and see if you can integrate. Kindly, Nadav
|
Hello Nadav, I'm going to have a look on your patch soon! Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a 33K users Moodle install. and for us to be able to run this (beautiful) report on a per course basis, without timeout errors, we needed to narrow the graphs population to the users of that specific course. (It's seems also the right thing to do, regardless performance)
So I am adding the suggested patch to include only the users of the specific course being viewed.
Please review and see if you can integrate.
Kindly,
Nadav