[WIP] Use reagent components as parent & other small fixes #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
oxalorg
commented
Aug 3, 2024
•
oxalorg
commented
- Allows using reagent components as parents
- README minor fixes
- Preserve user options provided to set-tokens, and make pretty-print configurable for generated css
oxalorg
force-pushed
the
ox/donavan-shelf-changes
branch
from
5d05bca to
1d762ae
Compare
oxalorg
force-pushed
the
ox/donavan-shelf-changes
branch
from
1d762ae to
320999c
Compare
plexus
reviewed
Aug 4, 2024
| @@ -46,6 +46,11 @@ | |||
| props-registry | |||
| (atom {}))) | |||
|
|
|||
| #?(:clj | |||
| (defonce ^{:doc "Store of passed in custom options/tokens"} | |||
There was a problem hiding this comment.
This would store all the tokens set from different places and show the last overriden tokens. This means options like pretty-print? can then be accessed later in the ornament code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.