Redo watch test as a vector of lines instead of a string. #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #411 +/- ##
=======================================
Coverage 75.08% 75.08%
=======================================
Files 52 52
Lines 2802 2802
Branches 289 289
=======================================
Hits 2104 2104
Misses 511 511
Partials 187 187
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This test is difficult to work with as-is because it's one big string, and deep-diff2 (currently) shows only that two strings differ, and not the substrings in particular that cause the mismatch.
alysbrooks
force-pushed
the
alys/improve-watch-test
branch
from
48bedb0 to
acf8fb7
Compare
It seems to run into quadratic behavior if I try to compare every line. This is slightly less accurate of a test, though.
Artificially dividing it up produced weird errors when there was a mismach. Using equals results in more coherent diffs and only required adding a few lines. I also didn't have that much confidence that a different change in test output wouidn't trigger a long delay. This does make the test slightly more fragile, as any thing added to the beginning of the output or the end of the output will cause this to fail. Also, if there's more lines in the output than in the test, you don't get a great diff either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is difficult to work with as-is because it's one big string, and deep-diff2 (currently) shows only that two strings differ, and not the substrings in particular that cause the mismatch.