Make kaocha.jit/jit thread-safe

lambdaisland · Dec 22, 2024 · a27bad1 · a27bad1
1 parent 15e553d
commit a27bad1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
 ## Fixed
 
 - Fix beholder watch functionality that would cause a NullPointerException earlier.
+- Make `kaocha.jit/jit` thread-safe in Clojure 1.10+. For lower versions, best effort with printed warning.
 
 ## Changed
 

diff --git a/src/kaocha/jit.clj b/src/kaocha/jit.clj
@@ -4,5 +4,11 @@
   "Just in time loading of dependencies."
   [sym]
   `(do
-     (require '~(symbol (namespace sym)))
+     (locking ~(if (and (<= 1 (:major *clojure-version*))
+                        (<= 10 (:minor *clojure-version*)))
+                 'clojure.lang.RT/REQUIRE_LOCK
+                 (do (binding [*err* *out*]
+                       (println "WARNING: kaocha.jit is not thread-safe before Clojure 1.10"))
+                     ::lock))
+       (require '~(symbol (namespace sym))))
      (find-var '~sym)))