-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(l2): restart processes with the proposed API #1234
Open
fborello-lambda
wants to merge
14
commits into
process-refactor
Choose a base branch
from
l2/restart_processes
base: process-refactor
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+540
−378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fborello-lambda
force-pushed
the
l2/restart_processes
branch
from
November 22, 2024 13:09
1402544
to
c39f934
Compare
fborello-lambda
force-pushed
the
l2/restart_processes
branch
from
November 22, 2024 18:11
216f0c4
to
7134c81
Compare
jrchatruc
reviewed
Nov 22, 2024
jrchatruc
reviewed
Nov 22, 2024
jrchatruc
reviewed
Nov 22, 2024
jrchatruc
reviewed
Nov 22, 2024
jrchatruc
reviewed
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The error handling should be the same for all processes, unwraps have to be handled with the
?
operator so that the api can restart the process if anyErr
is raised.Description
unwraps
in prover_server.rs #1168not committed block
error.verify()
function of theOnChainProposer
contract was changed to throw the correct error. The error handling with the proposed API does the rest.require
Errors in OnChainProposer Verification #1164.Closes #1168
Closes #1165
Closes #1164