Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(l1): replace info! with debug! tracing log #1174

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore(l1): replace info! with debug! tracing log #1174

wants to merge 3 commits into from
+14 −14

Conversation

h3lio5
Copy link
Contributor

@h3lio5 h3lio5 commented Nov 14, 2024

Motivation

Replace info! tracing logs with debug! to avoid flooding the console.

Closes #1134

@h3lio5 h3lio5 requested a review from a team as a code owner November 14, 2024 17:13
@h3lio5 h3lio5 changed the title replace tracing info with debug messages feat(l1): replace tracing info with debug messages Nov 14, 2024
@h3lio5 h3lio5 changed the title feat(l1): replace tracing info with debug messages chore(l1): replace tracing info with debug messages Nov 14, 2024
@h3lio5 h3lio5 changed the title chore(l1): replace tracing info with debug messages chore(l1): replace info! with debug! tracing log Nov 14, 2024
@h3lio5
Copy link
Contributor Author

h3lio5 commented Nov 14, 2024

From the issue description, I understand that the debug! log content should also be made clearer (or less verbose). But this PR doesn't make changes to the log messages though.

ElFantasma
ElFantasma requested changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@ElFantasma ElFantasma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but it's a bit outdated: there are some changes in main that should be addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElFantasma ElFantasma ElFantasma requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace all p2p protocol info! messages by debug! messages
2 participants
@h3lio5 @ElFantasma