Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[55] Add ABI tests #75

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[55] Add ABI tests #75

wants to merge 7 commits into from

Conversation

prietoestefi
Copy link

Added tests for ABI

@prietoestefi prietoestefi marked this pull request as ready for review June 2, 2022 13:35
eth_client/test/abi_test.exs Outdated Show resolved Hide resolved
eth_client/test/abi_test.exs Outdated Show resolved Hide resolved
jpcenteno
jpcenteno previously approved these changes Jun 6, 2022
eth_client/test/abi_test.exs Outdated Show resolved Hide resolved
address = '0x0'

assert_raise MatchError, fn ->
ABI.get(address)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should create a ticket to change this function in order to return an {:error, :invalid_address} or something like that.

@mfachal mfachal linked an issue Jun 8, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write unit tests for lib/eth_client/abi.ex
4 participants